feat: add isNonEmptyArray #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
char0n
requested changes
Jan 17, 2018
| @@ -0,0 +1,23 @@ | |||
| import * as RA from '../src/index'; | |||
| import eq from './shared/eq'; | |||
|
|
|||
|
|
||
| import isNotEmpty from './isNotEmpty'; | ||
| import isArray from './isArray'; | ||
|
|
| /** | ||
| * Checks if input value is a non empty `Array`. | ||
| */ | ||
| isNonEmptyArray(val: any): val is Array<any>; |
There was a problem hiding this comment.
@BjornMelgaard I'm not sure about this. Can you advice ? Does this signature make sense in the context of empty array ?
There was a problem hiding this comment.
@char0n I think yes, there is no way we can express that array is non-empty in types
There was a problem hiding this comment.
Wouldn't be better to use boolean instead ?
There was a problem hiding this comment.
when isNonEmptyArray returns false array methods still can be applied on name
so val is Array<any> if fine )
src/isNonEmptyArray.js
Outdated
| * RA.isNonEmptyArray(42); // => false | ||
| * RA.isNonEmptyArray('42'); // => false | ||
| */ | ||
| const isNonEmptyArray = both(isNotEmpty, isArray); |
There was a problem hiding this comment.
I'd prefer one of the following compositions:
const isNonEmptyArray = both(isArray, isNotEmpty);or
const isNonEmptyArray = both(isArray, complement(isEmptyArray));
Merged
added 2 commits
January 18, 2018 16:49
according to char0n#279, checking if something is array is simpler then checking if an value is not empty.
63e1653 to
c83c16d
Compare
char0n
approved these changes
Jan 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #279