What about a RA.isNotEmptyArray ?

[guillaumearm]

Hello everyone,

Frequently, I implement myself a isNotEmptyArray function :

const isNotEmptyArray = R.both(RA.isArray, RA.isNotEmpty);

I think I'm not alone to doing that, maybe I could make a PR for adding this function ?

We should add isEmptyArray, isEmptyObject and isNotEmptyObject too.

[char0n]

Yes, I have the same usecase in the current codebase I'm working on. But I'd go for a following naming:
isEmptyArray, isNonEmptyArray.

Why ? You can read more about why here: #40

#40 is also dealing with isEmptyString and isNonEmptyString.

You can own both this and #40 issue and make them realize ;]

[char0n]

@guillaumearm I've assigned this issue to v2.4.0 milestone. Feel free to provide PR.

[guillaumearm]

Yup, i prefer the 'isNonEmpty' terminology too.

PR coming tommorow ;-)

and I would like to say ramda-adjunct is an awesome library, the missing piece of ramda.

Thank you for your work.

[char0n]

Thanks, and you'll be the next one to make it even better ;]

Please make two separate PRs for isEmptyArray and isNonEmptyArray. Check out this PR as an example of how a PR should look like.

[guillaumearm]

And what do you think about isEmptyObject and isNonEmptyObject ?

[char0n]

@guillaumearm let's continue object discussion here #283

[char0n]

From some reason I don't see isNotEmptyArray in generated docs for v2.4.0 https://char0n.github.io/ramda-adjunct/2.4.0/index.html

[guillaumearm]

'cause it's isNonEmptyArray
https://char0n.github.io/ramda-adjunct/2.4.0/RA.html#.isNonEmptyArray

[char0n]

Of course ;]