Fix annotations #690
Merged
Fix annotations #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Can now pass annotations to build. - Publish includes annotations from yaml. Signed-off-by: Adrian Mouat <adrian@chainguard.dev>
imjasonh
reviewed
May 22, 2023
Yeah, I wanted to do this, but wasn't quite sure where to put it! I was hoping there was a similar test I could crib from. |
This was referenced May 22, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
annotationflag toapko buildfor equivalence withpublish.It also fixes a bug where the annotations from the yaml config were deleted.
This PR could do with some tests - I'd appreciate any advice on where/how to add these.