Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test Suite #691

Open
amouat opened this issue May 22, 2023 · 1 comment
Open

Add Test Suite #691

amouat opened this issue May 22, 2023 · 1 comment

Comments

@amouat
Copy link
Contributor

amouat commented May 22, 2023

I'd really like to see a test suite that runs the apko binary against various inputs and verifies the outputs.

I'm not sure if there's a tool to use for this - I'd probably just use a bash script myself, but I'm we might want something a bit more structured :)

A lot of this does get tested downstream, but the more we can catch upstream, the better.

The original impetus for this was I wanted somewhere to easily add a test for the changes in #690

@deitch
Copy link
Contributor

deitch commented May 22, 2023

I would be fine with something that just calls whatever func is called by the cli (whatever the cobra.command.RunE calls), so it is easier to write in go. But either way, exercising the entire chain would be a good thing.

We do have two types of full on build tests:

  • we build everything in examples/ for one architecture, and one of them for all architectures
  • we build and test several images, see stuff in hack/ci/, with thanks to @jdolitsky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants