Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update schemas and documentation (fixes #25) #27

Merged
merged 15 commits into from
Aug 23, 2023
Merged

Fix: Update schemas and documentation (fixes #25) #27

merged 15 commits into from
Aug 23, 2023

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Aug 16, 2023 •
edited
Loading

Fixes #25

Fix

  • Update README.md with new properties
  • Update README.md to reflect required framework version
  • Update properties.schema
  • Update newer schemas in /schema
  • Update example.json with missing properties
  • Fix alt property not being used. Will now use alt for the aria-label and will fallback to navLabel if not set.

@swashbuck swashbuck self-assigned this Aug 16, 2023
@swashbuck swashbuck added the bug label Aug 16, 2023
@swashbuck swashbuck mentioned this pull request Aug 17, 2023
Closed
@swashbuck swashbuck marked this pull request as ready for review August 18, 2023 17:50
@swashbuck swashbuck mentioned this pull request Aug 18, 2023
Closed
kirsty-hames
kirsty-hames approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks @swashbuck. I've tested this in legacy AAT, with a submenu course setup.

I've raised a comment querying if _hideBackButton is needed at course level but no biggie either way.

schema/course.schema.json Outdated Show resolved Hide resolved
@kirsty-hames kirsty-hames merged commit 81bf7e5 into master Aug 23, 2023
@kirsty-hames kirsty-hames deleted the issue/25 branch August 23, 2023 10:14
github-actions bot pushed a commit that referenced this pull request Aug 23, 2023
@semantic-release-bot
Chore(release): 1.1.1 [skip ci]
35e31fc 
## [1.1.1](v1.1.0...v1.1.1) (2023-08-23)

### Fix

* Update schemas and documentation (fixes #25) (#27) ([81bf7e5](81bf7e5)), closes [#25](#25) [#27](#27)
@github-actions
Copy link

🎉 This PR is included in version 1.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@StuartNicholls StuartNicholls Awaiting requested review from StuartNicholls

@joe-allen-89 joe-allen-89 Awaiting requested review from joe-allen-89

Assignees

@swashbuck swashbuck

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update schemas
2 participants
@swashbuck @kirsty-hames