Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appears to be breaking access to the Project Settings page #26

Closed
fosterc1 opened this issue Aug 16, 2023 · 16 comments · Fixed by #29
Closed

Appears to be breaking access to the Project Settings page #26

fosterc1 opened this issue Aug 16, 2023 · 16 comments · Fixed by #29
Assignees

Comments

@fosterc1
Copy link

Subject of the issue/enhancement/features

Without the plugin within the course the Project settings page can be accessed, when v1.1.0 of the plugin is added, the Project settings page displays no content.

Your environment

  • version (AT v0.11.1/Framework v5.31.22)
  • which browser and its version
  • device(s) + operating system(s)

Steps to reproduce

Add the Home Button plugin

Expected behaviour

To be able to access the Project setting page

Actual behaviour

Can click the Project settings page link, but nothing is displayed

Screenshots (if you can)

2023-08-16_11-14-21

@swashbuck
Copy link
Contributor

swashbuck commented Aug 16, 2023

@fosterc1 There is a known issue where the schemas need to be updated #25 . Are you able to use an older version of the plugin until that's fixed (hopefully by this week or next at the latest)?

@swashbuck swashbuck added the bug label Aug 16, 2023
@swashbuck
Copy link
Contributor

Also, this now requires Framework version 5.30.3 or higher. This will be updated in the readme.

@swashbuck
Copy link
Contributor

swashbuck commented Aug 18, 2023

@fosterc1 PR is ready for review. Should fix the schema issues.

#27

Let me know if we can close this ticket. Thanks.

@fosterc1
Copy link
Author

Not sure how I review this tbh, do you have a link to the updated zip file to upload the plugin?

@swashbuck
Copy link
Contributor

@fosterc1 This was actually just merged into master, so you can update with the latest release (v1.1.1).

@fosterc1
Copy link
Author

Hello

@swashbuck v1.1.1 is still breaking the Project settings page.

Thanks

@swashbuck
Copy link
Contributor

@fosterc1 What version of the Vanilla theme are you using?

@fosterc1
Copy link
Author

@swashbuck v9.8.3

@swashbuck
Copy link
Contributor

Thanks, @fosterc1 . Can you click in Configuration settings? Are you seeing any console errors in the browser?

@fosterc1
Copy link
Author

Hello @swashbuck

This is definately an issue in the plugin, as I've created a fresh environment with a new course. All is working well until v1.1.1 of the Home plugin is installed.

Command failed: npx grunt server-build:prod --outputdir=courses/64e89acc247fae32da097501/64e89c616a106533e1567d91/build --theme=64e89b1a247fae32da097595 --menu=adapt-contrib-boxMenu
Plugin folder name 64e89b1a247fae32da097595 does not match package name adapt-contrib-vanilla.

Hope this helps

@swashbuck
Copy link
Contributor

Thanks, @fosterc1

I don't suppose you have access to an AAT v0.10.5 testing environment? Home Button was working in one of our v0.10.5 sandbox sites.

Regardless, we will keep looking into this.

@swashbuck
Copy link
Contributor

^^ Nevermind about the AAT version. We've managed to break it in v0.10.5, too.

@swashbuck
Copy link
Contributor

swashbuck commented Sep 26, 2023

@taylortom Would you be able to take a look at this? I'm not sure where we left off, but I know there was an AAT patch floating around somewhere. Would the patch fix this issue?

Note that I do have PR #29 started for this.

@swashbuck
Copy link
Contributor

@taylortom Do you think v0.11.2 of adapt_authoring would fix this issue?

https://github.com/adaptlearning/adapt_authoring/blob/master/CHANGELOG.md#0112---2023-09-25

@swashbuck
Copy link
Contributor

@fosterc1 Are you able to reproduce the issue in AAT v0.11.2 and using the PR #29 ? We think this combination will fix the issue.

@swashbuck swashbuck assigned fosterc1 and unassigned taylortom Oct 4, 2023
swashbuck added a commit that referenced this issue Oct 6, 2023
* Add missing inputType properties
* Add some help properties
github-actions bot pushed a commit that referenced this issue Oct 6, 2023
## [1.1.2](v1.1.1...v1.1.2) (2023-10-06)

### Fix

* Fix properties.schema (fixes #26) ([745826c](745826c)), closes [#26](#26)
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

🎉 This issue has been resolved in version 1.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants