-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Add support for Tooltip API and Navigation Button API (fixes #16 #23) #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated code in 3466fc7 as part of review rather than leaving suggestions.
If the button can be overriden at a contentObject level as per the original issue, the schema will need updating to reflect this. If including the ability to use different labels, should this be extended to _classes
and _iconClasses
too? Is homeButton an appropriate name if it can be redirected any _id
?
Thanks for the changes, @danielghost
Yep, agreed. The schema updates are still pending. I just wanted to nail down the data structure first. You can ignore the schema changes that are currently attached to this PR.
I don't know that this is necessary? The button's class is essentially determined by the
This is a good point, but I feel that it would be out of scope for this ticket and better handled in a new one? It would definitely be a breaking change. Again, though, I would like to hear what others think. |
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Fixes #16 #23
Fix
Testing
Configure a course per example.json
To test overrides, add the config to a menu or content object. Then, simply use a non-empty value for the text that should be overridden (ex.
_homeButton.navLabel
or_homeButton.alt
). In the AAT, these values should default to empty, so adding any text will override them.To do