Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Tooltip API and Navigation Button API #16

Closed
kirsty-hames opened this issue Oct 19, 2022 · 2 comments · Fixed by #24
Closed

Add support for Tooltip API and Navigation Button API #16

kirsty-hames opened this issue Oct 19, 2022 · 2 comments · Fixed by #24
Assignees
@swashbuck
Labels
enhancement question released

Comments

@kirsty-hames
Copy link
Contributor

For consistency with other navigation buttons when tooltips are enabled, homeButton should support the Core tooltip API adaptlearning/adapt-contrib-core#207

Note, this might require a slightly different implementation as the button can be redirected so would need to support the use case for the tooltip text to be overwritten where applicable. Example, redirecting the home button to a start page.

My initial suggestion is to keep the standard home button tooltip config as per the existing tooltip functionality - we can assume the default will be 'home' (menu). With the addition to overwrite 'tooltip' within the _homeButton config. I'd be keen to get input or suggestions on this?
@swashbuck swashbuck self-assigned this Jul 17, 2023
@swashbuck swashbuck changed the title Add support for tooltip API Add support for Tooltip API and Navigation Button API Jul 19, 2023
@swashbuck
Copy link
Contributor

Added Navigation Button API to the ticket title. I'll do these both at the same time.

This was referenced Jul 19, 2023
Closed
Merged
oliverfoster added a commit that referenced this issue Aug 14, 2023
@oliverfoster
New: Add support for Tooltip API and Navigation Button API (fixes #16 #…
04fbc9e 
…23)
github-actions bot pushed a commit that referenced this issue Aug 14, 2023
@semantic-release-bot
Chore(release): 1.1.0 [skip ci]
c64e043 
# [1.1.0](v1.0.7...v1.1.0) (2023-08-14)

### New

* Add support for Tooltip API and Navigation Button API (fixes #16 #23) ([04fbc9e](04fbc9e)), closes [#16](#16) [#23](#23)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
enhancement question released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New: Add support for Tooltip API and Navigation Button API (fixes #16 #23) cgkineo/adapt-homeButton
2 participants
@swashbuck @kirsty-hames