Skip to content

Commit

Permalink
Merge pull request #7565 from cert-manager-bot/cherry-pick-7549-to-re…
Browse files Browse the repository at this point in the history
…lease-1.17

[release-1.17] chore(issuer/cloudflare): ensure we set ZoneID
  • Loading branch information
cert-manager-prow[bot] authored Feb 12, 2025
2 parents bec3f95 + 47828f2 commit c658224
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions pkg/issuer/acme/dns/cloudflare/cloudflare.go
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,10 @@ func (c *DNSProvider) findTxtRecord(ctx context.Context, fqdn, content string) (

for _, rec := range records {
if rec.Name == util.UnFqdn(fqdn) && rec.Content == content {
// Cloudflare made a breaking change to their API and removed the ZoneID from responses:
// https://developers.cloudflare.com/fundamentals/api/reference/deprecations/#2024-11-30
// The simplest fix is to set the ZoneID manually here
rec.ZoneID = zoneID
return &rec, nil
}
}
Expand Down

0 comments on commit c658224

Please sign in to comment.