Skip to content

Commit

Permalink
Add comment explaining change
Browse files Browse the repository at this point in the history
Signed-off-by: Ashley Davis <SgtCoDFish@users.noreply.github.com>
  • Loading branch information
SgtCoDFish authored and cert-manager-bot committed Feb 12, 2025
1 parent 2121860 commit 47828f2
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pkg/issuer/acme/dns/cloudflare/cloudflare.go
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,9 @@ func (c *DNSProvider) findTxtRecord(ctx context.Context, fqdn, content string) (

for _, rec := range records {
if rec.Name == util.UnFqdn(fqdn) && rec.Content == content {
// Cloudflare made a breaking change to their API and removed the ZoneID from responses:
// https://developers.cloudflare.com/fundamentals/api/reference/deprecations/#2024-11-30
// The simplest fix is to set the ZoneID manually here
rec.ZoneID = zoneID
return &rec, nil
}
Expand Down

0 comments on commit 47828f2

Please sign in to comment.