Update for RC6 chain and GSRPC versions #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikiquantum
commented
Sep 30, 2020
| @@ -148,13 +148,6 @@ type Events struct { | |||
| ChainBridge_RelayerAdded []EventRelayerAdded //nolint:stylecheck,golint | |||
| ChainBridge_RelayerThresholdChanged []EventRelayerThresholdChanged //nolint:stylecheck,golint | |||
| Nfts_DepositAsset []EventNFTDeposited //nolint:stylecheck,golint | |||
| Council_Proposed []types.EventCollectiveProposed //nolint:stylecheck,golint | |||
There was a problem hiding this comment.
Already part of GSRPC events
| @@ -1,7 +1,7 @@ | |||
| version: '3' | |||
| services: | |||
| cc: | |||
| image: "centrifugeio/centrifuge-chain:20200625211147-5e0e5e1" | |||
| image: "centrifugeio/centrifuge-chain:20200928161532-a960a81" | |||
Codecov Report
@@ Coverage Diff @@
## develop #1439 +/- ##
===========================================
- Coverage 66.94% 66.92% -0.03%
===========================================
Files 167 167
Lines 10613 10614 +1
===========================================
- Hits 7105 7103 -2
- Misses 2739 2742 +3
Partials 769 769
Continue to review full report at Codecov.
|
vedhavyas
approved these changes
Oct 6, 2020
|
@mikiquantum looks like there is another PR with substrate v2.0.0 changes centrifuge/go-substrate-rpc-client#100. Is it worth the time to wait for that to get in and update this accordingly ? |
|
@vedhavyas I would not, since that version might not be compatible with our chain. |
mikiquantum
added a commit
that referenced
this pull request
Oct 13, 2020
This reverts commit 7b26e2e. modified: .travis.yml modified: build/scripts/docker/docker-compose-bridge.yml modified: build/scripts/docker/docker-compose-cc.yml deleted: build/scripts/test-dependencies/bridge/config/config.example.json new file: build/scripts/test-dependencies/bridge/config/config.example.toml modified: build/scripts/test-dependencies/bridge/create_config.sh modified: centchain/api.go modified: centchain/events.go modified: go.mod modified: go.sum modified: resources/data.go
mikiquantum
added a commit
that referenced
this pull request
Oct 13, 2020
* Use temp fix for indices * Revert "Fix Docker subkey (#1440)" This reverts commit 2381280. modified: Dockerfile * Revert "Update for RC6 chain and GSRPC versions (#1439)" This reverts commit 7b26e2e. modified: .travis.yml modified: build/scripts/docker/docker-compose-bridge.yml modified: build/scripts/docker/docker-compose-cc.yml deleted: build/scripts/test-dependencies/bridge/config/config.example.json new file: build/scripts/test-dependencies/bridge/config/config.example.toml modified: build/scripts/test-dependencies/bridge/create_config.sh modified: centchain/api.go modified: centchain/events.go modified: go.mod modified: go.sum modified: resources/data.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.