-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Substrate v2.0.0 #100
Conversation
Need to work on travis tests... |
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 57.70% 57.77% +0.06%
==========================================
Files 92 93 +1
Lines 3114 3230 +116
==========================================
+ Hits 1797 1866 +69
- Misses 962 987 +25
- Partials 355 377 +22
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LaurentTrk LGTM! Thanks for the contribution. Only one comment about removing support for v1 in the Makefile. I will merge up after that.
@LaurentTrk that is very interesting, I can label the PR, Do you have any more information that I can link as well to the PR && issue? |
No more information, the label is enough. Thanks !! Pretty sure you know about Hacktoberfest, but just in case https://hacktoberfest.digitalocean.com/ |
There has been some changes between the Substrate 2.0.0-rc6 and the final one, that need to be reported in this rpc client:
I hope I've done things right ;)