Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Substrate v2.0.0 #100

Merged
merged 8 commits into from
Oct 6, 2020
Merged

Conversation

LaurentTrk
Copy link
Contributor

There has been some changes between the Substrate 2.0.0-rc6 and the final one, that need to be reported in this rpc client:

I hope I've done things right ;)

@LaurentTrk LaurentTrk closed this Oct 5, 2020
@LaurentTrk
Copy link
Contributor Author

Need to work on travis tests...

@LaurentTrk LaurentTrk reopened this Oct 6, 2020
@LaurentTrk LaurentTrk closed this Oct 6, 2020
@LaurentTrk LaurentTrk reopened this Oct 6, 2020
@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #100 into master will increase coverage by 0.06%.
The diff coverage is 59.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   57.70%   57.77%   +0.06%     
==========================================
  Files          92       93       +1     
  Lines        3114     3230     +116     
==========================================
+ Hits         1797     1866      +69     
- Misses        962      987      +25     
- Partials      355      377      +22     
Impacted Files Coverage Δ
types/metadataV12.go 52.52% <52.52%> (ø)
types/metadata.go 71.73% <100.00%> (+3.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 305d63b...0e9198a. Read the comment docs.

Copy link
Contributor

@mikiquantum mikiquantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LaurentTrk LGTM! Thanks for the contribution. Only one comment about removing support for v1 in the Makefile. I will merge up after that.

Makefile Outdated Show resolved Hide resolved
@mikiquantum
Copy link
Contributor

@LaurentTrk that is very interesting, I can label the PR, Do you have any more information that I can link as well to the PR && issue?

@LaurentTrk
Copy link
Contributor Author

LaurentTrk commented Oct 6, 2020

No more information, the label is enough. Thanks !!

Pretty sure you know about Hacktoberfest, but just in case https://hacktoberfest.digitalocean.com/

@mikiquantum mikiquantum merged commit 3e97443 into centrifuge:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants