docs(README): Add instructions for airgap deployment (fixes #104) #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Provide detailed steps for how to move Docker images across an airgap. - The rest of the installation is the same. - Also refactor the way we build certs into the Docker image. The old approach required editing the dockerfile, which was led certain people (i.e. myself) to accidentally check in the Dockerfile with their own issuer cert configured in it. The new approach passes the information in the environment.
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
=======================================
Coverage 95.63% 95.63%
=======================================
Files 9 9
Lines 847 847
=======================================
Hits 810 810
Misses 37 37 Continue to review full report at Codecov.
|
emmanvg
reviewed
Feb 25, 2022
emmanvg
reviewed
Feb 25, 2022
emmanvg
reviewed
Feb 25, 2022
134065c to
824992e
Compare
Fix docker lint errors
824992e to
da8b4a2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
emmanvg
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide detailed steps for how to move Docker images across an airgap.
The rest of the installation is the same.
Also refactor the way we build certs into the Docker image. The old approach
required editing the dockerfile, which led certain people ( me) to
accidentally check in the Dockerfile with their own issuer cert configured in
it. The new approach passes the information in the environment.
closes Airgap Deployment of TRAM #104