This repository has been archived by the owner on Nov 7, 2022. It is now read-only.
Remove broken checksums now caught by go 1.11.4 #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We ran into a similar issue when building with go1.11.4. See census-ecosystem/opencensus-experiments#138. /cc @rghetia |
songy23
approved these changes
Jan 8, 2019
added 3 commits
January 9, 2019 18:44
f192cb7 to
fd6c0a7
Compare
fivesheep
pushed a commit
to fivesheep/opencensus-service
that referenced
this pull request
Jun 12, 2019
…on#283) * Remove broken checksums now caught by go 1.11.4 See golang/go#29278 for more info. * Update related MD files * Fix build_binaries docker
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was in contact with someone trying to build the repo and his golang was a new install (via brew). So he hit the same issue as Travis w/ go 1.11.4 (see #272): invalid checksum.
The problem for us is that the recommendation for this issue is to remove the old checksum, this fixes the build for go 1.11.4. However, any previous go version is going to re-introduce the incorrect checksums (I tested only with go 1.11.1). So if we merge this change and don't upgrade go to 1.11.4 on our boxes we are going to keep getting a modified go.sum (re-introducing the wrong checksums), which is fine as long as people are aware of the issue and don't commit the go.sum - in other words if this PR is merged any changes to go.mod/go.sum need to be done using go 1.11.4 and above.
See golang/go#29278 for more info about the change in golang.
Creating as DO NOT MERGE so we can discuss and perhaps adopt some other alternative, however, notice that someone setting up a brand new go env is likely to hit the issue and be unable to build the repo.
PS.: I remember in the past using brew to switch between go 1.10 and 1.11 but I am not sure if we can easily do the same for minor versions.