This repository has been archived by the owner on Nov 7, 2022. It is now read-only.
Fix travis pass #272
Merged
Fix travis pass #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Dec 15, 2018
fivesheep
pushed a commit
to fivesheep/opencensus-service
that referenced
this pull request
Jun 12, 2019
* Tidy go.mod and go.sum (Travis failures) * Going back to go 1.11.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Travis issue hit on PR #271.
Go was update recenlty and Travis moved to version 1.11.4 in my tests the issue didn't repro with 1.11.2. I didn't try 1.11.3 since it mentions problems with go get, from https://golang.org/doc/devel/release.html#go1.11.minor:
go1.11.3 (released 2018/12/12) includes three security fixes to "go get" and the crypto/x509 package. See the Go 1.11.3 milestone on our issue tracker for details.
go1.11.4 (released 2018/12/14) includes fixes to cgo, the compiler, linker, runtime, documentation, go command, and the net/http and go/types packages. It includes a fix to a bug introduced in Go 1.11.3 that broke go get for import path patterns containing "...". See the Go 1.11.4 milestone on our issue tracker for details.
Since I was testing go.mod and go.sum took the chance to tidy them.