Add Span kind to the Span. #51
Conversation
|
|
||
| // Indicates that the span covers the client-side wrapper around an RPC or | ||
| // other remote request. | ||
| CLIENT = 2; |
There was a problem hiding this comment.
I would add PRODUCER and CONSUMER as they are widely used, and indicate sending to a broker instead of directly to a server and visa versa
There was a problem hiding this comment.
OpenTracing also has producer and consumer types. Might be good if we have that.
|
This is good progress, and CLIENT/SERVER is already handled in census by grpc instrumentation (and the upcoming http work). Let's not forget PRODUCER/CONSUMER but I agree that there should be some code driving that. In java you can look at this https://github.com/openzipkin/brave/tree/master/instrumentation/kafka-clients and also the span kind definition in zipkin for later stuff. For now, let's merge as it gets a large percentage of instrumentation.. instrumentable. |
Proposal for adding a span kind that can be used also as an identity for the Span, this way we can remove the prefix "Sent." and "Recv." from the span names in grpc and http.