Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

SpanKind support #525

Closed
semistrict opened this issue Mar 7, 2018 · 4 comments
Closed

SpanKind support #525

semistrict opened this issue Mar 7, 2018 · 4 comments
Assignees
@rakyll
Labels
P0 trace

Comments

@semistrict
Copy link
Contributor

SpanKind is now part of OpenCensus trace proto. We should support it as a first class citizen in Go. See: census-instrumentation/opencensus-proto#51
@semistrict semistrict mentioned this issue Mar 7, 2018
Closed
@rakyll
Copy link
Contributor

rakyll commented Mar 7, 2018

Is this API breaking anymore? We are going to make it an option.

@semistrict
Copy link
Contributor Author

Guess not

@codefromthecrypt
Copy link

fwiw in zipkin-go @basvanbeek made lack of kind a special kind (at the api level which is not strictly bound to the format) https://github.com/openzipkin/zipkin-go/blob/master/model/kind.go

@rakyll rakyll mentioned this issue Mar 20, 2018
Closed
@rakyll rakyll self-assigned this Mar 20, 2018
rakyll added a commit to rakyll/opencensus-go that referenced this issue Mar 20, 2018
@rakyll
Introduce SpanKind support
92d7381 
Updates census-instrumentation#525.
@rakyll rakyll mentioned this issue Mar 20, 2018
Merged
rakyll added a commit to rakyll/opencensus-go that referenced this issue Mar 20, 2018
@rakyll
Introduce SpanKind support
654094e 
Updates census-instrumentation#525.
rakyll added a commit to rakyll/opencensus-go that referenced this issue Mar 20, 2018
@rakyll
Introduce SpanKind support
0ae87ab 
Updates census-instrumentation#525.
@rakyll rakyll mentioned this issue Mar 20, 2018
Closed
rakyll added a commit that referenced this issue Mar 20, 2018
@rakyll
Introduce SpanKind support (#610)
0967e1d 
Updates #525.
@rakyll rakyll added the P0 label Mar 29, 2018
@rakyll
Copy link
Contributor

rakyll commented Mar 29, 2018

Closed via #610 and #616.

@rakyll rakyll closed this as completed Mar 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rakyll rakyll

Labels
P0 trace
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codefromthecrypt @rakyll @semistrict