Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add useSafe for governance:propose and governance:withdraw #511

Merged
merged 8 commits into from
Jan 24, 2025
Merged

feat: add useSafe for governance:propose and governance:withdraw #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
db12d53
feat: add useSafe for governance:propose
nicolasbrugneaux Jan 17, 2025
f8c4ca4
feat: add useSafe for governance:withdraw
nicolasbrugneaux Jan 17, 2025
bc23577
docs: reword ambiguous `safe`
nicolasbrugneaux Jan 17, 2025
a558fae
docs: regenerate docs
nicolasbrugneaux Jan 17, 2025
1e1adae
fix: bad refactor
nicolasbrugneaux Jan 17, 2025
9e0d366
chore: add changeset
nicolasbrugneaux Jan 22, 2025
f7231a0
fix: test
nicolasbrugneaux Jan 24, 2025
dea0a5b
Merge branch 'master' into nicolasbrugneaux/use-safe
nicolasbrugneaux Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/late-dolphins-crash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@celo/celocli': minor
---

Add useSafe flags for governance:propose and governance:withdraw commands
22 changes: 18 additions & 4 deletions docs/command-line-interface/governance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ FLAGS
True means the request will be sent through multisig.

--useSafe
True means the request will be sent through safe.
True means the request will be sent through SAFE (http://safe.global)

DESCRIPTION
Approve a dequeued governance proposal (or hotfix)
Expand Down Expand Up @@ -580,8 +580,9 @@ USAGE
<value> | --useLedger | ] [-n <value>] [--gasCurrency
0x1234567890123456789012345678901234567890] [--ledgerAddresses <value> ]
[--ledgerLiveMode ] [--globalHelp] [--for 0xc1912fEE45d61C87Cc5EA59DaE31190FFFFf232d
--useMultiSig] [--force] [--noInfo] [--afterExecutingProposal <value> |
--afterExecutingID <value>]
[--useMultiSig | --useSafe]] [--safeAddress
0xc1912fEE45d61C87Cc5EA59DaE31190FFFFf232d ] [--force] [--noInfo]
[--afterExecutingProposal <value> | --afterExecutingID <value>]

FLAGS
-k, --privateKey=<value>
Expand Down Expand Up @@ -633,12 +634,18 @@ FLAGS
--noInfo
Skip printing the proposal info

--safeAddress=0xc1912fEE45d61C87Cc5EA59DaE31190FFFFf232d
Address of the safe.

--useLedger
Set it to use a ledger wallet

--useMultiSig
True means the request will be sent through multisig.

--useSafe
True means the request will be sent through SAFE (http://safe.global).

DESCRIPTION
Submit a governance proposal

Expand Down Expand Up @@ -1407,7 +1414,8 @@ USAGE
<value> | --useLedger | ] [-n <value>] [--gasCurrency
0x1234567890123456789012345678901234567890] [--ledgerAddresses <value> ]
[--ledgerLiveMode ] [--globalHelp] [--for 0xc1912fEE45d61C87Cc5EA59DaE31190FFFFf232d
--useMultiSig]
[--useMultiSig | --useSafe]] [--safeAddress
0xc1912fEE45d61C87Cc5EA59DaE31190FFFFf232d ]

FLAGS
-k, --privateKey=<value>
Expand Down Expand Up @@ -1438,12 +1446,18 @@ FLAGS
the 5th. This is useful to use same address on you Ledger with celocli as you do on
Ledger Live

--safeAddress=0xc1912fEE45d61C87Cc5EA59DaE31190FFFFf232d
Address of the safe.

--useLedger
Set it to use a ledger wallet

--useMultiSig
True means the request will be sent through multisig.

--useSafe
True means the request will be sent through SAFE (http://safe.global).

DESCRIPTION
Withdraw refunded governance proposal deposits.

Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/commands/governance/approve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export default class Approve extends BaseCommand {
exclusive: ['useSafe'],
}),
useSafe: Flags.boolean({
description: 'True means the request will be sent through safe.',
description: 'True means the request will be sent through SAFE (http://safe.global)',
exclusive: ['useMultiSig'],
}),
hotfix: Flags.string({
Expand Down
Loading
Loading