Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add useSafe for governance:propose and governance:withdraw #511

Merged
merged 8 commits into from
Jan 24, 2025

Conversation

nicolasbrugneaux
Copy link
Contributor

@nicolasbrugneaux nicolasbrugneaux commented Jan 17, 2025


PR-Codex overview

This PR introduces useSafe flags for the governance:propose and governance:withdraw commands, enhancing the governance functionality to support transactions through the SAFE protocol.

Detailed summary

  • Added useSafe flag to governance:propose and governance:withdraw commands.
  • Updated descriptions to include SAFE protocol link.
  • Introduced SafeFlags in flags.ts with useSafe and safeAddress.
  • Modified transaction functions to handle SAFE transactions.
  • Updated tests to cover scenarios with SAFE integration.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@nicolasbrugneaux nicolasbrugneaux self-assigned this Jan 17, 2025
Copy link

changeset-bot bot commented Jan 17, 2025

🦋 Changeset detected

Latest commit: dea0a5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@celo/celocli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.45%. Comparing base (4a1d9e7) to head (dea0a5b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
+ Coverage   76.40%   76.45%   +0.05%     
==========================================
  Files         247      247              
  Lines       10424    10448      +24     
  Branches     1636     1664      +28     
==========================================
+ Hits         7964     7988      +24     
- Misses       2352     2373      +21     
+ Partials      108       87      -21     
Components Coverage Δ
celocli 86.77% <100.00%> (+0.08%) ⬆️
sdk 68.96% <ø> (ø)
wallets 73.30% <ø> (ø)
viem-sdks 95.08% <ø> (ø)

@nicolasbrugneaux nicolasbrugneaux marked this pull request as ready for review January 17, 2025 16:09
@nicolasbrugneaux nicolasbrugneaux requested a review from a team as a code owner January 17, 2025 16:09
@nicolasbrugneaux nicolasbrugneaux force-pushed the nicolasbrugneaux/use-safe branch from d39f08c to 1e1adae Compare January 17, 2025 16:40
@aaronmgdr
Copy link
Member

looking good

@nicolasbrugneaux nicolasbrugneaux merged commit be62336 into master Jan 24, 2025
24 of 37 checks passed
@nicolasbrugneaux nicolasbrugneaux deleted the nicolasbrugneaux/use-safe branch January 24, 2025 09:29
@github-actions github-actions bot mentioned this pull request Jan 24, 2025
aaronmgdr pushed a commit that referenced this pull request Jan 31, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to master, this PR
will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`master` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `master`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @celo/celocli@6.1.0-beta.1

### Minor Changes

- [#511](#511)
[`be62336`](be62336)
Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Add
useSafe flags for governance:propose and governance:withdraw commands

- [#510](#510)
[`0d307db`](0d307db)
Thanks [@shazarre](https://github.com/shazarre)! - Add
`epochs:send-validator-payment` command to support sending validator,
their group and delegation beneficiary allocated epoch payments

### Patch Changes

- [#514](#514)
[`4a1d9e7`](4a1d9e7)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix bug with
GovernanceSlasher missing version causing failure. defend against
exceptions when printing contracts info

- Updated dependencies
\[[`0d307db`](0d307db),
[`a8e5099`](a8e5099)]:
    -   @celo/contractkit@9.0.1-beta.1
    -   @celo/wallet-ledger@7.0.0-beta.1
    -   @celo/wallet-hsm-azure@7.0.0-beta.1
    -   @celo/wallet-local@7.0.0-beta.1

## @celo/wallet-ledger@7.0.0-beta.1

### Minor Changes

- [#516](#516)
[`a8e5099`](a8e5099)
Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Add
(Beta) support for signTypedData in @celo/viem-account-ledger and
@celo/wallet-ledger when using with the `ethereum` ledger app.
    when using with the `ethereum` ledger app.

### Patch Changes

-   Updated dependencies \[]:
    -   @celo/wallet-base@7.0.0-beta.1
    -   @celo/wallet-remote@7.0.0-beta.1

## @celo/viem-account-ledger@1.1.0-beta.1

### Minor Changes

- [#516](#516)
[`a8e5099`](a8e5099)
Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Add
(Beta) support for signTypedData in @celo/viem-account-ledger and
@celo/wallet-ledger when using with the `ethereum` ledger app.
    when using with the `ethereum` ledger app.

## @celo/contractkit@9.0.1-beta.1

### Patch Changes

- [#510](#510)
[`0d307db`](0d307db)
Thanks [@shazarre](https://github.com/shazarre)! - Expose
`sendValidatorPayment` methods for `EpochManager` contract wrapper

-   Updated dependencies \[]:
    -   @celo/wallet-local@7.0.0-beta.1

## @celo/wallet-hsm-aws@7.0.0-beta.1

### Patch Changes

-   Updated dependencies \[]:
    -   @celo/wallet-base@7.0.0-beta.1
    -   @celo/wallet-hsm@7.0.0-beta.1
    -   @celo/wallet-remote@7.0.0-beta.1

## @celo/wallet-hsm-azure@7.0.0-beta.1

### Patch Changes

-   Updated dependencies \[]:
    -   @celo/wallet-base@7.0.0-beta.1
    -   @celo/wallet-hsm@7.0.0-beta.1
    -   @celo/wallet-remote@7.0.0-beta.1

## @celo/wallet-hsm-gcp@7.0.0-beta.1

### Patch Changes

-   Updated dependencies \[]:
    -   @celo/wallet-base@7.0.0-beta.1
    -   @celo/wallet-hsm@7.0.0-beta.1
    -   @celo/wallet-remote@7.0.0-beta.1

## @celo/wallet-local@7.0.0-beta.1

### Patch Changes

-   Updated dependencies \[]:
    -   @celo/wallet-base@7.0.0-beta.1

## @celo/wallet-remote@7.0.0-beta.1

### Patch Changes

-   Updated dependencies \[]:
    -   @celo/wallet-base@7.0.0-beta.1

## @celo/wallet-base@7.0.0-beta.1



## @celo/wallet-hsm@7.0.0-beta.1




<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating various packages to version `7.0.0-beta.1`
and `9.0.1-beta.1`, along with minor changes and dependency updates
across the Celo SDK and related libraries.

### Detailed summary
- Updated versions in `CHANGELOG.md` for multiple packages to
`7.0.0-beta.1`.
- Updated `@celo/wallet-base` version to `7.0.0-beta.1` in several
`package.json` files.
- Added new entries in `CHANGELOG.md` for `@celo/viem-account-ledger`
and `@celo/contractkit`.
- Introduced minor changes in `@celo/celocli` and `@celo/wallet-ledger`
with new commands and features.
- Updated dependencies for multiple packages to reflect the new
versions.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`

<!-- end pr-codex -->

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expand --useSafe to more commands
3 participants