When resetting and upgrading a VM testnet, new tx-nodes are included in the new instance group #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #771 +/- ##
=======================================
Coverage 66.16% 66.16%
=======================================
Files 261 261
Lines 7599 7599
Branches 440 440
=======================================
Hits 5028 5028
Misses 2476 2476
Partials 95 95
Continue to review full report at Codecov.
|
timmoreton
approved these changes
Oct 3, 2019
…r/vm-testnet-instance-group
…g/celo-monorepo into trevor/vm-testnet-instance-group
aaronmgdr
added a commit
that referenced
this pull request
Oct 4, 2019
* master: [Protocol] Fix network id for alfajores in truffle configs (#1211) When resetting and upgrading a VM testnet, new tx-nodes are included in the new instance group (#771) Upload static VM testnet nodes, add stackdriver logging (#750) Revert "Make packages depend on git vesrion (not npm)" (#1201) Make packages depend on git vesrion (not npm) (#1192) [contractkit] Document methods (#1195) [ck] consistent send tx object in kit (#1191) Move docker images to use node v10 (#1183) [ContractKit]Fill more fields before web3 signing (#1133) [codecov]Fix codecov errors (#1147) [Wallet] Add support for address pasting in send input field (#1180) Fix verification pool validation (#1176) Improve QR Code scan ability (#1036) Add CLI commands around identity metadata (#1167) [wallet]Run geth in an infura-like mode (#1108) # Conflicts: # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ensures that when running
celotooljs deploy upgrade vm-testnet --reset, the tx-node instance group includes the new tx-nodes. Because of some restraints imposed by Terraform, this is done by creating the tx-nodes and instance group before destroying it (this is the suggested behavior). In order to avoid name conflicts (which made GCP force the deployment to fail), random suffixes were added to the names of the resources.Tested
Ran
celotooljs deploy upgrade vm-testnet --resetand saw that the new tx-nodes were included in the new instance groupOther changes
n/a
Related issues
Backwards compatibility
Yes