[wallet]Run geth in an infura-like mode #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4261f0 to
e09e8dd
Compare
8544cbe to
54a24c1
Compare
jmrossy
reviewed
Sep 27, 2019
annakaz
approved these changes
Sep 27, 2019
There was a problem hiding this comment.
Tested locally with yarn run dev and build the integration sdk to test. Can import a wallet, exchange gold and dollars both directions, and send dollars.
Note that the transaction feed is not loading on integration, but it is not loading on master either and seems untouched in this PR.
0a6351d to
ea2690c
Compare
|
Tested again. Can't get SMS verification to work but that's broken on the master as well. |
ea2690c to
ef9d930
Compare
ef9d930 to
8fc4a75
Compare
* Remove private key from logging * Make infura setup work with https I was trying to use infura-like setup with `ws` (Web sockets). Since `ws` sends plain-text, it does not work in prouduction. We cannot use `wss` since it is not supported natively by geth - ethereum/go-ethereum#16423 Even K8s only supports https. To avoid this issue, I shifted to https. Subscriptions don't work with https, so, a crude polling mechanism to check for transaction confirmations. Also, in this commit, change the nonce count to include "pending" transactions, so that, multiple transactions can be sent without waiting for completion. * Handle nonce related to simultaneous transactions Handle the case when too many transactions are sent close to each other. Geth has `web3.eth.getTransactionCount(account, 'pending')` but even that only seems to work once the transactions have made to the transaction pool. Therefore, for transactions sent too close to each other, which is the case for SMS verification transactions, maintain a local nonce and ensure that new Nonce is equal or greater than local nonce. * Increment nonce before sending transaction Otherwise, the next transaction might not get the right nonce. * Fix some issues pointed by Rossy * Remove artifical wait
e4c57ac to
f19a6fb
Compare
|
I don't know why |
f19a6fb to
4d1497e
Compare
4d1497e to
e104181
Compare
Codecov Report
@@ Coverage Diff @@
## master #1108 +/- ##
==========================================
- Coverage 66.83% 66.06% -0.77%
==========================================
Files 261 261
Lines 7492 7564 +72
Branches 503 437 -66
==========================================
- Hits 5007 4997 -10
- Misses 2387 2471 +84
+ Partials 98 96 -2
Continue to review full report at Codecov.
|
aaronmgdr
added a commit
that referenced
this pull request
Oct 4, 2019
* master: [Protocol] Fix network id for alfajores in truffle configs (#1211) When resetting and upgrading a VM testnet, new tx-nodes are included in the new instance group (#771) Upload static VM testnet nodes, add stackdriver logging (#750) Revert "Make packages depend on git vesrion (not npm)" (#1201) Make packages depend on git vesrion (not npm) (#1192) [contractkit] Document methods (#1195) [ck] consistent send tx object in kit (#1191) Move docker images to use node v10 (#1183) [ContractKit]Fill more fields before web3 signing (#1133) [codecov]Fix codecov errors (#1147) [Wallet] Add support for address pasting in send input field (#1180) Fix verification pool validation (#1176) Improve QR Code scan ability (#1036) Add CLI commands around identity metadata (#1167) [wallet]Run geth in an infura-like mode (#1108) # Conflicts: # yarn.lock
jmrossy
added a commit
that referenced
this pull request
Oct 7, 2019
* Implement new import wallet flow designs including empty wallet warning * Improve responsiveness of import wallet screen * More robust error handling for import saga * Add tests for import saga * Cleanup redundant web3 zerosync mocks introduced in #1108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run mobile app without running a local geth instance. Connect to
{testnet}-infura.celo-testnet.orgfor example, https://integration-infura.celo-testnet.org`Tested
DEFAULT_TESTNET=integrationandDEFAULT_SYNC_MODE=-1inpackages/mobile/.envfile.yarn run dev.celotooljs account invite -e integration --phone <phone number>to get SMS.Related issues