Adds initializableV2 contract to ensure implementation contracts are initialized #7254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
388fc39 to
1221a8a
Compare
m-chrzan
reviewed
Feb 24, 2021
m-chrzan
reviewed
Mar 21, 2021
m-chrzan
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new contract InitializableV2 that is the same at the Initializable contract but with the addition of a constructor which sets _initialized == true unless the isTest parameter is true. This prevents the implementation contracts from being initialized and effectively locks their storage. Rather than upgrade all our contracts to use InitializableV2 at once, we will selectively make this change to contracts that we are upgrading anyway. To enforce this, a check has been added to the backwards compatibility script to ensure that contracts with positive version deltas do not use the old Initializable contract. This PR upgrades the ReleaseGold, GoldToken, and MetaTransactionWallet contracts to use InitializableV2 and reverts the changes that were previously added to initialize ReleaseGold contracts on deploy.
Other changes
Last few commits make it so the deploy_release_contracts script runs in CI, which it turns out it was not previously. You can see the "Deploying ReleaseGold..." output now shows in the logs.
Tested
Tested with a variety of contracts in this PR #7196
Related issues
https://app.zenhub.com/workspaces/cap-sprint-board-60059934ed9c6f000e5594f6/issues/celo-org/celo-monorepo/6577
Backwards compatibility
Yes