Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core contract release process should include step to verify PRs to be audited with author #7470

Closed
kevjue opened this issue Mar 18, 2021 · 1 comment
Closed

core contract release process should include step to verify PRs to be audited with author #7470

kevjue opened this issue Mar 18, 2021 · 1 comment
Assignees
@yorhodes
Labels
CAP Component: Contracts
Milestone
Milestone 11

Comments

@kevjue
Copy link
Contributor

kevjue commented Mar 18, 2021

Expected Behavior

All PRs that are assigned to be audited should be verified by the PR author (unless the author is external).

E.g. for Release 4, this PR was initially designated to be audited. But @alecps later mentioned that it was going to be reverted.

Current Behavior

PRs designated to be audited are not verified by the PR author.
@alecps alecps added this to the Milestone 10 milestone Apr 15, 2021
@alecps alecps modified the milestones: Milestone 10, Milestone 11 Apr 28, 2021
@yorhodes
Copy link
Contributor

yorhodes commented May 4, 2021

closed with updates to https://www.notion.so/clabsco/Release-Process-9876c6c0773249d687c6c2413e7bab76

@yorhodes yorhodes closed this as completed May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yorhodes yorhodes

Labels
CAP Component: Contracts
Projects
None yet
Milestone
Milestone 11
Development

No branches or pull requests
3 participants
@yorhodes @kevjue @alecps