Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README toc #1975

Closed
wants to merge 4 commits into from
Closed

README toc #1975

wants to merge 4 commits into from

Conversation

KoenBal
Copy link
Contributor

@KoenBal KoenBal commented Nov 30, 2019

Description

Added a Table of Content as part of multiple README updates

As part of a larger README update
#1974
#1973
#1972
#1971
#1970
#1969

README GrowthHacking

@timmoreton timmoreton self-assigned this Dec 4, 2019
@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #1975 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1975      +/-   ##
==========================================
+ Coverage   74.42%   74.45%   +0.02%     
==========================================
  Files         281      281              
  Lines        7824     7817       -7     
  Branches      687      685       -2     
==========================================
- Hits         5823     5820       -3     
+ Misses       1884     1880       -4     
  Partials      117      117
Flag Coverage Δ
#mobile 74.45% <ø> (+0.02%) ⬆️
Impacted Files Coverage Δ
packages/mobile/src/import/ImportWalletEmpty.tsx 78.78% <0%> (-0.63%) ⬇️
packages/mobile/src/localCurrency/saga.ts 69.23% <0%> (+1.37%) ⬆️
packages/mobile/src/import/ImportWallet.tsx 95.83% <0%> (+5.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdc4839...1c98941. Read the comment docs.

@KoenBal
Copy link
Contributor Author

KoenBal commented Dec 6, 2019

@timmoreton Should I do something here? Was it correct to split up each part of the file in a new branch? Or am I taking a bad approach here?

@timmoreton timmoreton closed this Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants