Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README added mission #1972

Merged
merged 3 commits into from
Dec 5, 2019
Merged

README added mission #1972

merged 3 commits into from
Dec 5, 2019

Conversation

KoenBal
Copy link
Contributor

@KoenBal KoenBal commented Nov 30, 2019

Descriptions

Added the mission statement
Added an embed image + link to youtube video

Rationale: For some users the celo monorepo could be the first impression they have of celo. A
A nice README is a good way to help people engage in the project as well. A project with nice README and screenshots will get the attention of users better since it’s a direct way to explain why this project matters, and why people should use and contribute to the project. Good README should also include enough details to help a new user get started, e.g. how to compile, how to install, and how to start integrating.

README educational content I used.
A beginners guide to writing kickass readmes
AWESOME READMEs

@codecov
Copy link

codecov bot commented Nov 30, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@426b6d5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1972   +/-   ##
=========================================
  Coverage          ?   74.45%           
=========================================
  Files             ?      281           
  Lines             ?     7817           
  Branches          ?      973           
=========================================
  Hits              ?     5820           
  Misses            ?     1880           
  Partials          ?      117
Flag Coverage Δ
#mobile 74.45% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 426b6d5...ce6dee2. Read the comment docs.

@KoenBal KoenBal mentioned this pull request Nov 30, 2019
@timmoreton timmoreton self-assigned this Dec 4, 2019
@@ -9,6 +9,19 @@ and other packages.

The source code for the Celo Blockchain which operates a node on the Celo Network is kept in a separate repo [here](https://github.com/celo-org/celo-blockchain).

### Celo's Mission - Prosperity for All
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timmoreton timmoreton merged commit eff7f62 into celo-org:master Dec 5, 2019
aaronmgdr added a commit that referenced this pull request Dec 5, 2019
* master: (208 commits)
  Fix potential hard timeouts (#2072)
  Add checkzero,blockscout,mulit-address support to faucet. Fix broken envType checks (#2068)
  README added mission (#1972)
  Add dev-utils README (#2081)
  Add validator:status command to check if a validator signer is online and producing blocks (#1906)
  Experience Brand Kit 1.0 (#1948)
  Adjust reference to the rewards app (#2065)
  [Wallet] Compatibility with exchange rate in string format (#2060)
  Fix Typo in CI config (#2056)
  Fix additional attestations instructions (#2057)
  Allow a specified address to disable/enable rewards distribution (#1828)
  Aaronmgdr/leaderboard patch (#2055)
  Move attestation service instructions to main page (#2051)
  Point To Updated Join Celo Video (#2052)
  Fix minor issue withe the ordering of instructions
  changes to docs related to discovery (#2025)
  [Docs] Fix typos in Running a Validator docs (#2045)
  Add node flag to celocli to set the target node for a single command (#2020)
  Fix broken links and spruce up CLI docs for accounts command (#2027)
  Prevent clipping of arrow component (#2036)
  ...

# Conflicts:
#	packages/web/src/layout/BookLayout.tsx
#	packages/web/src/lib.dom.d.ts
@KoenBal KoenBal deleted the README_mission branch December 5, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants