fixes for the testnet stateful sets #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1049 +/- ##
=======================================
Coverage 66.94% 66.94%
=======================================
Files 252 252
Lines 7322 7322
Branches 415 415
=======================================
Hits 4902 4902
Misses 2334 2334
Partials 86 86
Continue to review full report at Codecov.
|
nambrot
approved these changes
Sep 18, 2019
mergify bot
pushed a commit
that referenced
this pull request
Dec 19, 2020
### Description Upgrade sentry/react-native from 1.7.1 to 2.1.0. This is part of our effort to improve debugging capabilities. With this update we hope to see better stack traces in some native crashes where the entire trace is missing. I went through the release notes for each of the releases since 1.7.1 to make sure we capture any breaking changes and to see what has been fixed and what to watch out for. One thing that has been added is release health which we should discuss whether we want on or off: https://blog.sentry.io/2020/05/19/crash-free-sessions-carefree-users-with-release-health What's new in sentry: - Bump sentry-android to 3.2.0 getsentry/sentry-react-native#1208 - Fix: set userId for hard-crashes if no user is set [#1049](getsentry/sentry-java#1049) - Bump @sentry/javascript dependencies to [5.28.0](getsentry/sentry-react-native#1228) - Bump sentry-cocoa to [6.0.9](getsentry/sentry-react-native#1200) ### Other changes Set sentry automatic session tracking explicitly off because the default has changed in 2.0. Not sure yet if we want that on so I set it off to be explicit. ### Tested Manually causing crashes in JS: `throw new Error("My first Sentry error!");` and in native: `Sentry.nativeCrash();` ### Related issues - Fixes #6203 ### Backwards compatibility Yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There appears to be extra curly braces in the statefulsets files.
Tested
Deployed a new testnet.
Other changes
None
Backwards compatibility
Is backwards compatible.