Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Upgrade sentry sdk SDK from version 1.7.1 to version 2.1.0 #6203

Closed
etuleu opened this issue Dec 11, 2020 · 0 comments · Fixed by #6280
Closed

[Wallet] Upgrade sentry sdk SDK from version 1.7.1 to version 2.1.0 #6203

etuleu opened this issue Dec 11, 2020 · 0 comments · Fixed by #6280

Comments

@etuleu
Copy link
Contributor

etuleu commented Dec 11, 2020

Expected Behavior

Good stack traces that are actionable.

Current Behavior

Some of the stack traces have little information or just say "undefined" and I think sentry has made some fixes recently.

@etuleu etuleu added the wallet label Dec 11, 2020
@etuleu etuleu self-assigned this Dec 11, 2020
@mergify mergify bot closed this as completed in #6280 Dec 19, 2020
mergify bot pushed a commit that referenced this issue Dec 19, 2020
### Description

Upgrade sentry/react-native from 1.7.1 to 2.1.0.

This is part of our effort to improve debugging capabilities. With this update we hope to see better stack traces in some native crashes where the entire trace is missing.

I went through the release notes for each of the releases since 1.7.1 to make sure we capture any breaking changes and to see what has been fixed and what to watch out for.

One thing that has been added is release health which we should discuss whether we want on or off: https://blog.sentry.io/2020/05/19/crash-free-sessions-carefree-users-with-release-health

What's new in sentry:

- Bump sentry-android to 3.2.0 getsentry/sentry-react-native#1208
- Fix: set userId for hard-crashes if no user is set [#1049](getsentry/sentry-java#1049) 
- Bump @sentry/javascript dependencies to [5.28.0](getsentry/sentry-react-native#1228)
- Bump sentry-cocoa to [6.0.9](getsentry/sentry-react-native#1200)


### Other changes
Set sentry automatic session tracking explicitly off because the default has changed in 2.0. Not sure yet if we want that on so I set it off to be explicit.


### Tested

Manually causing crashes in JS:
`throw new Error("My first Sentry error!");`
and in native:
`Sentry.nativeCrash();`

### Related issues

- Fixes #6203

### Backwards compatibility

Yes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants