Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring!(rpc/cmd): rework rpc commands #2812

Merged
merged 11 commits into from
Oct 5, 2023
Merged

refactoring!(rpc/cmd): rework rpc commands #2812

merged 11 commits into from
Oct 5, 2023

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Oct 5, 2023 •
edited
Loading

Overview

  • reworked p2p/das/header/share/admin/state cmds
  • extracted cmds to the respective packages in nodebuilder
  • added rpc flag that allows to specify a path for the node's config
  • removed deprecated endpoints
  • removed authEnvKey in favour of authToke/node.store path

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs added area:rpc kind:break! Attached to breaking PRs kind:refactor Attached to refactoring PRs labels Oct 5, 2023
@vgonkivs vgonkivs self-assigned this Oct 5, 2023
vgonkivs added 11 commits October 5, 2023 16:23
@vgonkivs
feat(cmd/rpc): add commands for the p2p module (celestiaorg#2599)
e6e8402
@vgonkivs
feat(rpc): add daser cmd (celestiaorg#2651)
ae7a1d8
@vgonkivs
cmd(rpc): add header cmd (celestiaorg#2658)
c89ada1
@vgonkivs
feat(rpc): add share cmd (celestiaorg#2664)
e216544
@vgonkivs
feat(rpc): add admin cmd (celestiaorg#2701)
c38fcb7
@vgonkivs
feat(rpc): add state cmd (celestiaorg#2691)
cc02d71
@vgonkivs
refactor(cmd): extract rpc cmds (celestiaorg#2706)
0d081eb
@vgonkivs
refactor(rpc/blob) extend docs in blob (celestiaorg#2755)
f6a1e9d
@vgonkivs
feat(cmd/rpc): add node store flag (celestiaorg#2762)
f596e11
@vgonkivs
refactor(gateway): remove deprecated endpoints (celestiaorg#2764)
76ced90
@vgonkivs
refactoring(rpc): remove authEnvKey (celestiaorg#2810)
9ef7594 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords
@vgonkivs vgonkivs force-pushed the rpc_cmds_feature_branch branch from d8a4e96 to 9ef7594 Compare October 5, 2023 13:23
@codecov-commenter
Copy link

Codecov Report

Merging #2812 (9ef7594) into main (403a39e) will decrease coverage by 0.58%.
The diff coverage is 15.09%.

@@            Coverage Diff             @@
##             main    #2812      +/-   ##
==========================================
- Coverage   51.91%   51.33%   -0.58%     
==========================================
  Files         161      167       +6     
  Lines       10827    10752      -75     
==========================================
- Hits         5621     5520     -101     
- Misses       4713     4751      +38     
+ Partials      493      481      -12
Files Coverage Δ
cmd/celestia/bridge.go 100.00% <100.00%> (ø)
cmd/celestia/rpc.go 100.00% <100.00%> (+82.14%) ⬆️
cmd/flags_node.go 0.00% <ø> (ø)
api/gateway/endpoints.go 0.00% <0.00%> (ø)
cmd/celestia/full.go 88.00% <0.00%> (ø)
cmd/celestia/light.go 88.00% <0.00%> (ø)
api/gateway/state.go 0.00% <0.00%> (-9.05%) ⬇️
cmd/auth.go 0.00% <0.00%> (ø)
cmd/rpc.go 0.00% <0.00%> (ø)
cmd/util.go 18.29% <18.29%> (ø)

... and 16 files with indirect coverage changes

@vgonkivs vgonkivs merged commit 0b5fc0b into celestiaorg:main Oct 5, 2023
@vgonkivs vgonkivs mentioned this pull request Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamsi liamsi liamsi approved these changes

@distractedm1nd distractedm1nd distractedm1nd approved these changes

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@Wondertan Wondertan Awaiting requested review from Wondertan Wondertan is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees

@vgonkivs vgonkivs

Labels
area:rpc kind:break! Attached to breaking PRs kind:refactor Attached to refactoring PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vgonkivs @codecov-commenter @liamsi @distractedm1nd