New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CLI documentation for blob submit #2707

Closed

adlerjohn opened this issue Sep 15, 2023 · 1 comment

Assignees

Labels

documentation good first issue

Member

adlerjohn commented Sep 15, 2023

The celestia rpc blob submit method has the following docs:

Flags:
      --fee int          specifies fee for blob submission (default -1)
      --gas.limit uint   specifies max gas for the blob submission

The denomination of the fee isn't documented.
The -1 magic number isn't documented. If it's -1 does it do something automatically? If yes, why not just do that when --fee isn't specified?
The documentation for gas limit says "max gas" but really it's just "gas" since all gas is consumed.

The text was updated successfully, but these errors were encountered:

adlerjohn added the documentation label

adlerjohn assigned vgonkivs

distractedm1nd added the good first issue label

vgonkivs mentioned this issue

refactor(rpc/blob) extend docs in blob #2755

Merged

5 tasks

Member

vgonkivs commented Oct 5, 2023

Fixed in scope of the global rpc rework. #2812

vgonkivs closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment