Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(header/p2p): add peerScore decreasing in case of failed request #1603

Merged
merged 10 commits into from
Jan 18, 2023
Merged

fix(header/p2p): add peerScore decreasing in case of failed request #1603

merged 10 commits into from
Jan 18, 2023

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Jan 16, 2023 •
edited
Loading

Overview

Resolves #1607

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs requested a review from renaynay as a code owner January 16, 2023 13:23
@vgonkivs vgonkivs self-assigned this Jan 16, 2023
@Wondertan Wondertan mentioned this pull request Jan 16, 2023
Closed
@vgonkivs vgonkivs force-pushed the add_timeout_in_session branch from e4f5f44 to 552a9a5 Compare January 16, 2023 15:37
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023 •
edited
Loading

Codecov Report

Merging #1603 (a562652) into main (2d6d138) will increase coverage by 0.07%.
The diff coverage is 81.08%.

@@            Coverage Diff             @@
##             main    #1603      +/-   ##
==========================================
+ Coverage   54.08%   54.16%   +0.07%     
==========================================
  Files         222      222              
  Lines       14411    14425      +14     
==========================================
+ Hits         7794     7813      +19     
+ Misses       5758     5752       -6     
- Partials      859      860       +1
Impacted Files Coverage Δ
header/p2p/options.go 63.06% <50.00%> (-1.99%) ⬇️
header/p2p/exchange.go 66.25% <100.00%> (ø)
header/p2p/peer_stats.go 97.18% <100.00%> (+0.21%) ⬆️
header/p2p/server.go 74.21% <100.00%> (ø)
header/p2p/session.go 87.83% <100.00%> (+7.43%) ⬆️
nodebuilder/header/module.go 97.72% <100.00%> (+0.02%) ⬆️
share/eds/byzantine/bad_encoding.go 66.00% <0.00%> (-3.00%) ⬇️
header/p2p/helpers.go 67.39% <0.00%> (+4.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Wondertan
Wondertan reviewed Jan 16, 2023
View reviewed changes
header/p2p/options.go Outdated Show resolved Hide resolved
header/p2p/options.go Outdated Show resolved Hide resolved
header/p2p/peer_stats.go Show resolved Hide resolved
whatsa4
whatsa4 previously approved these changes Jan 16, 2023
View reviewed changes
@vgonkivs vgonkivs requested a review from Wondertan January 17, 2023 12:04
renaynay
renaynay reviewed Jan 17, 2023
View reviewed changes
header/p2p/exchange_test.go Outdated Show resolved Hide resolved
header/p2p/exchange_test.go Outdated Show resolved Hide resolved
header/p2p/exchange_test.go Outdated Show resolved Hide resolved
header/p2p/session.go Outdated Show resolved Hide resolved
distractedm1nd
distractedm1nd suggested changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@distractedm1nd distractedm1nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have the same question as rene, otherwise just comment nits

header/p2p/options.go Outdated Show resolved Hide resolved
header/p2p/options.go Outdated Show resolved Hide resolved
@vgonkivs vgonkivs force-pushed the add_timeout_in_session branch from f3167ed to b970a55 Compare January 17, 2023 22:35
@Bidon15 Bidon15 mentioned this pull request Jan 18, 2023
Closed
renaynay
renaynay previously approved these changes Jan 18, 2023
View reviewed changes
header/p2p/session.go Outdated Show resolved Hide resolved
renaynay
renaynay previously approved these changes Jan 18, 2023
View reviewed changes
Wondertan
Wondertan reviewed Jan 18, 2023
View reviewed changes
header/p2p/options.go Outdated Show resolved Hide resolved
header/p2p/peer_stats.go Show resolved Hide resolved
@vgonkivs vgonkivs force-pushed the add_timeout_in_session branch from 01a552a to 426e296 Compare January 18, 2023 10:50
@Bidon15 Bidon15 requested a review from whatsa4 January 18, 2023 11:18
@vgonkivs vgonkivs merged commit 534ec0d into celestiaorg:main Jan 18, 2023
@Wondertan Wondertan mentioned this pull request Jan 20, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaynay renaynay renaynay approved these changes

@Wondertan Wondertan Wondertan approved these changes

@distractedm1nd distractedm1nd distractedm1nd approved these changes

@whatsa4 whatsa4 Awaiting requested review from whatsa4

Assignees

@vgonkivs vgonkivs

Labels
area:header Extended header area:p2p
Projects
No open projects
Celestia Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improvement(header/p2p): add request timeout param in headerEx
6 participants
@vgonkivs @codecov-commenter @distractedm1nd @Wondertan @renaynay @whatsa4