fix(header/p2p): set deadline on a request to peer #1592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
reviewed
Jan 13, 2023
| log.Errorw("requesting headers from peer failed.", "failed peer", stat.peerID, "err", err) | ||
| select { | ||
| case <-ctx.Done(): |
There was a problem hiding this comment.
why? we will request headers from another peer. Previous one, will not be added
There was a problem hiding this comment.
because then request won't be retried!
There was a problem hiding this comment.
ctx.Done succeds and the case s.reqCh <- req does not do anything
There was a problem hiding this comment.
yes, correctly. Sorry, I was blind on Friday
|
Closing in favour of #1603 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.