-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to Go 1.22 #1249
Conversation
Still observing build errors:
perhaps I have to bump godeltaprof? cc: @walldiss Update: I think I need godeltaprof v0.1.5+ |
Note this doesn't fix proto-check-breaking
I can reproduce the proto-check-breaking error locally:
It seems odd that v1.15.1 is used because the latest is much higher: 1.29.0. See https://github.com/bufbuild/buf/releases |
A bunch of linters are now failing but a few of them are disabled upstream. See https://github.com/cometbft/cometbft/blob/v0.34.x/.golangci.yml so we should disable revive and nakedret and likely fix the rest. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -154,7 +154,7 @@ endif | |||
|
|||
proto-gen: check-proto-deps | |||
@echo "Generating Protobuf files" | |||
@go run github.com/bufbuild/buf/cmd/buf generate | |||
@go run github.com/bufbuild/buf/cmd/buf@v1.29.0 generate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] To facilitate future refactoring and considering that a specific version of this repo has been designated for use, I recommend introducing a variable to hold this version number and employing it throughout the Makefile in order to simplify version updates in the future.
- libs/pubsub/query/query.peg.go | ||
goconst: | ||
ignore-tests: true | ||
depguard: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one 👍
Motivation
Part of #1248
We want to cut a release of celestia-core with Go 1.22 support to enable celestia-node to bump to Go 1.22.
Description