Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to run in Go 1.22 RC1 #90

Closed
franchb opened this issue Jan 15, 2024 · 2 comments
Closed

Fails to run in Go 1.22 RC1 #90

franchb opened this issue Jan 15, 2024 · 2 comments

Comments

@franchb
Copy link

franchb commented Jan 15, 2024

The code located in the example folder does not execute successfully on Go version 1.22 RC1.

go: finding module for package github.com/grafana/pyroscope-go
go: downloading github.com/grafana/pyroscope-go v1.0.4
go: found github.com/grafana/pyroscope-go in github.com/grafana/pyroscope-go v1.0.4
go: downloading github.com/grafana/pyroscope-go/godeltaprof v0.1.4
# github.com/grafana/pyroscope-go/godeltaprof/internal/pprof
../gopath602117689/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.4/internal/pprof/delta_mutex.go:25:20: undefined: runtime_cyclesPerSecond
../gopath602117689/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.4/internal/pprof/proto.go:400:8: undefined: runtime_expandFinalInlineFrame

https://go.dev/play/p/rFVOk4vZiJQ?v=gotip

@korniltsev
Copy link
Collaborator

does it still fail on the latest godeltaprof v0.1.6 ?

@korniltsev
Copy link
Collaborator

Im going to close this issue. godeltaprof should be working since 0.1.5 for go 1.22. Please reopen if you find issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants