-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReserveSpace parameter to StorageClass #103
Add ReserveSpace parameter to StorageClass #103
Conversation
Do you think this requires manual testing? |
If you like, you can add unit test in Go to see if the parameters applied are rendered correctly, see the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR :)
Have you run the command to generate the Chart readme? It seems to be missing, as well as the version bump in chart.yaml
Co-authored-by: Chris <github.account@chrigel.net>
I just ran What version should I bump to? |
Since this is a new feature, version
It should update the readme after you bump the version IIRC |
All done! |
Merged & released. |
Summary
Checklist
For Helm Chart changes
kind:bug
,kind:enhancement
,kind:documentation
,kind:change
,kind:breaking
,kind:dependency
as they show up in the changelog
area:chart
chart:kubernetes-zfs-provisioner
make chart-docs