-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional space reservation (thin provisioning) #102
Conversation
Thanks for your contribution! Documentation in the Readme is still missing (explain what the implication of thin-provisioning is). To test it, you can run |
…sistance with it)
…p for me, which i dont like.
I have added integration tests for thin provisioning and assertions that the To test this it was necessary to upgrade go-zfs, because the currently used version has a bug that makes it impossible to get dataset properties. Also don't look at the individual commits too much :') |
Just realized I forgot to update the Readme. |
Fixes #101
I'm going to test this next, but you can have a look at the code before I'm done.Has been tested.Also I'm going to send a separate PR in which I will add the parameter to the example config in the helm chart. #103
Summary
I've added an optional parameter to the storage classes, called "reserveSpace", which is true by default. When specified as "false", any datasets created when provisioning PVs using that storage class will not have a
RefReservation
set.Checklist
For Code changes
kind:bug
,kind:enhancement
,kind:documentation
,kind:change
,kind:breaking
,kind:dependency
as they show up in the changelog
area:provisioner
charts/
directory.