Added ElementsAre and UnorderedElementsAre #2133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0aa9e8e to
4ac161f
Compare
Codecov Report
@@ Coverage Diff @@
## devel #2133 +/- ##
=======================================
Coverage 90.03% 90.03%
=======================================
Files 146 146
Lines 7089 7089
=======================================
Hits 6382 6382
Misses 707 707 |
|
I was just wondering why this was closed? Do the maintainers not want this feature? I would love to see this in Catch! |
|
I honestly closed this because I had no idea how to properly test it and I didn't want to bother Horen as in #2114. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
ElementsAreandUnorderedElementsAregeneric range matchers which take a range during construction and theirmatchmethod take a range as well.GitHub Issues
Addressing issue #2087 .
Notes
I did not include support to providing a
matcheras construction argument due toElementsArewould be exactly the same asAllMatch.