Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow easier bullet pulling for simple ammo #886

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented Sep 15, 2021

Summary

SUMMARY: Balance "Allow easier uncrafting of pistol and shotgun rounds"

Purpose of change

The idea came up recently that bullet pulling could use some tweaks to make it so that blunderbuss rounds and other basic "I need to scrap some ammo I don't intend to use" recipes can be more accessible, at a point before you'd have the gunsmithing setup needed to make said options functionally obsolete. On noticing that pullers had level 2 pulling quality, but nothing actually used that quality, this led to the ideas below.

Also has the side effect of making pliers actually useful for something that wrenches can't do, so that pliers aren't completely obsolete once you find a wrench.

Describe the solution

  1. Implemented level 2 pulling quality being needed for all rifle-caliber ammo. When asked whether I should go with the realistic "level 2 for bottlenecked cartridges, rifle or not" option vs. basing it off pistol vs. rifle caliber, I was advised to go with the latter. Only real oddball here is 5x50mm because it's a sci-fi cartridge. Since the guns for it are flavored as sci-fi PDW stuff and the damage is rather low (side note, I should include that in the next round of the ammo rebalance when I can work out the next steps), went with retaining level 1 pulling quality for it.
  2. Changed shotshells, including .410, to use cutting quality instead of pulling. Represents needing to pry the shell open.
  3. Gave level 1 pulling quality to pliers and integrated toolset. As mentioned, kinetic bullet pullers already had level 2 pulling quality.
  4. Also added a mention of being useful for this to the description for pliers.
  5. Updated mods as well. Only thing really affected by this was the craftbuddy in Salvaged Robots.

Describe alternatives you've considered

  1. Implementing pulling 2 based off which cartridges are bottlenecked in real life instead of pistol vs. rifle caliber. If so then 7.62x25mm, 5.7x28mm, 4.6x36mm, and presumably 5x50mm (since it's basically 5.7mm but scifi) would require pulling quality 2, while .45-70 and .700 NE would revert back to pulling of 1.
  2. Adding pulling of 1 to large repair kits. Whereas the small variant is craftable and overtly includes a wrench in its recipe, the other one seems to be uncraftable and lacks an uncraft far as I can tell, so its actual contents are a mystery.
  3. Making 40mm either require pulling 2, or removing pulling requirement from it outright since it already requires different tool requirements and is probably the round least likely to have a puller that exists for it. Could go either way, or stay at current pulling requirement of 1, whatever works.
  4. Adding some sort of innawoods bullet puller with a mid-level autolearn, either an all-wood variant of the bullet puller (which would basically just be a mallet with a hole in it) or some sort of instrument similar to tongs in concept.
  5. Making rifle-tier and shotshell handloads not reversible, and specifying uncrafts for them instead, so they don't automatically convert demand for a press into pulling 1. The code that does this is in requirements.cpp and I can't think of any non-messy way to fix it at the hardcode level, doing it in JSON would be way simpler.

Testing

  1. Checked affected files for lint and syntax errors.
  2. Ported over file changes into test build to load-test.

Additional context

https://www.youtube.com/watch?v=0cbgZvcZ4VQ

@Coolthulhu Coolthulhu self-assigned this Sep 15, 2021
@Coolthulhu
Copy link
Member

Gave level 1 pulling quality to pliers, multi-tools, integrated toolset.

Multi-tools are already doing everything. Don't need the buff.

@chaosvolt
Copy link
Member Author

Multi-tools are already doing everything. Don't need the buff.

I did that mainly because multi-tools are flavored as having pliers, but guess it can be reasoned that the pliers don't give you a good enough grip to reliably pull bullets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants