Remove handload quality distinction

[KheirFerrum]

Summary

SUMMARY: "Ammo recipes create factory ammo instead of handloads. Added recipe for 5x50mm penetrators, 7.62x25mm Hot Load and 7.62x25mm Type P. Changed 38 Super to actually use 38 Super casings. Made uncraft and craft materials for ammo match."

Purpose of change

The idea of handloads being significantly worse than factory loaded ammunition is in fact unrealistic for skilled operators. Handloading ammo is an effective measure in modern times to save on costs or even to create more reliable ammunition.

In the process of this change it was learned that the uncraft recipes did not match the crafting recipes, producing more material than was needed to craft the ammo in question. Furthermore, the 38 Super ammunition used 38 casings instead of their own 38 super casings, which already exist in game and are used for 38 Super FMJ.

Describe the solution

Handload recipes were converted into Factory Ammo recipes by PoshOctavia on the Cataclysm Bright Nights Discord, who also edited the migration.json. I double-checked the code, and balanced the uncraft and craft recipes so that uncrafting a single load of ammo produced materials to craft said ammunition.

Some recipes were tweaked, for instance 4570 ammo used both ammo_bullet and lead in it's construction, leading to lead being used twice in the recipe at unrealistic amounts. The 38 Super was also changed so that it used and uncrafted into 38 super casings. The recipes were then obsoleted and the items moved to the obsoletion files.

Describe alternatives you've considered

Skill based increases in handloaded ammunition's damage, dispersion, accuracy and range.

• Would be considered my gold standard, but would require rewriting for some parts of the crafting system, or massive recipe bloat. As such, it was discarded.

Preserve some of the downsides of handloaded ammunition

• Seemed pointless, penalizing the player for using the crafting system on ammo for "realistic" reasons that don't include the benefits from said "realistic" model.

Testing

Created a save prior to the change with 5 of each reloaded version of ammo. Once changes done, checked that ammo was converted from handload to factory. Then disassembled and reassembled all ammo to ensure that no excess materials were gained.

Additional context

When I added some extra recipes for factory ammunition I neglected to add some of the blackpowder variants, maybe this could be added later, but right now I don't think it's very important. eg: 7.62x25 hot load and Type P lack Blackpowder variants.

[chaosvolt]

Side note, having removed "reversible": true, and retaining all relevant uncrafts fixes the issue I was having when I implemented #886, as rifle-tier handloads were getting a pulling requirement of 1 instead of 2 due to hardcoded handling of reversible recipes.

Blackpowder rifle cartridges will still be stuck with a different tier of pulling tool than the factor loads, but that's still a minor enough problem to save for another time.

[Coolthulhu]

I'm getting "invalid recipe reloaded_380_p".
I have all recipes unlocked on the character, so it should mean only this one isn't properly obsoleted.

data/json/itemgroups/Weapons_Mods_Ammo/ammo.json contains one missed entry of the reloaded variant.

[KheirFerrum]

I'm getting "invalid recipe reloaded_380_p". I have all recipes unlocked on the character, so it should mean only this one isn't properly obsoleted.

data/json/itemgroups/Weapons_Mods_Ammo/ammo.json contains one missed entry of the reloaded variant.

Yep, checked, it hadn't been added to the recipe obsoletion list.

While doing some checked I noticed that Generic guns had duplicate entries in their obsoletion files without any clear purpose, so I streamlined it.

Also it turns out I completely forgot to remove references to reloaded ammunition in the item groups, that's been fixed.