Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): allow hydraulic press to be grid furntiure, minor updates to press and brass items #6101

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented Feb 18, 2025

Purpose of change (The Why)

A pile of assorted follow-up updates to #6089

Describe the solution (The How)

  1. Moved hydraulic press furniture from furniture-tools.json to furniture-appliances.json, gave it a grid version of the hydraulic press as its crafting_pseudo_item, added EASY_DECONSTRUCT flag. Also removed the mention of "oops no power" from its description since it may in fact end up powered now.
  2. Defined a fake tool for grid hydraulic press to use, and a construction entry for placing a hydraulic press as grid furniture.
  3. Added looks_like entry for the hydraulic press item to resemble furniture form, updated description a bit, fixed up price a bit with string prices and a less intensely expensive postapoc price.
  4. Renamed cartridge brass to just brass to give us the option to take other potential sources of brass apart for it, updated description, and gave it a looks_like entry matching bronze.

Describe alternatives you've considered

Making an external tileset sprite for the hydraulic press item, but I'm eepy and lazy.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Load-tested in compiled test build.

Additional context

Checklist

Mandatory

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Feb 18, 2025
Copy link
Collaborator

@RobbieNeko RobbieNeko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobbieNeko RobbieNeko merged commit 26c38ae into cataclysmbnteam:main Feb 21, 2025
13 checks passed
@chaosvolt chaosvolt deleted the babe-it's-4-pm-time-for-your-brass-flattening branch February 21, 2025 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants