-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ammo casing recipes #6089
feat: Ammo casing recipes #6089
Conversation
Co-authored-by: RobbieNeko <30732426+RobbieNeko@users.noreply.github.com>
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
"difficulty": 5, | ||
"time": "5 m", | ||
"book_learn": [ [ "recipe_bullets", 2 ], [ "mag_rifle", 3 ] ], | ||
"tools": [ [ [ "hydraulic_press", 100 ] ], [ [ "forge", 50 ] ] ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use forging_standard
crafting requirement, not forges directly (as this disallows using an oxy torch). Note that 1 use of forging_standard
will be 20 charges, so I'd suggest using just 1 call to it especially since you're only making a single casing at a time with these recipes.
Whats everyone's opinion on adding swage and die set as a requirement as well I'm half half cause technically it makes sense but it'd be very abstracted compared to the actual thing and it feels somewhat misplaced |
Primers use swages, with firearm/gunsmith repair kits as secondary alternatives, so that seems reasonable to me. Gimme a bit I guess and I might slap together a suggestion review that'll combine that with the other feedback I left earlier. |
I alr got the file modified client side so I'd just update it here, I'm just waiting for more input :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big-ass review awawawa
Bundles the earlier suggestion of switching to a less-beefy chunk of forging_standard
with the tool addition, and as a sidequest tacks on a similar bit of toning down for how much hydraulic press charge is called for since being made 1 at a time.
"difficulty": 4, | ||
"time": "5 m", | ||
"book_learn": [ [ "recipe_bullets", 2 ], [ "mag_rifle", 3 ] ], | ||
"tools": [ [ [ "hydraulic_press", 100 ] ], [ [ "forge", 50 ] ] ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"tools": [ [ [ "hydraulic_press", 100 ] ], [ [ "forge", 50 ] ] ], | |
"tools": [ | |
[ [ "hydraulic_press", 10 ] ], | |
[ [ "forging_standard", 1, "LIST" ] ], | |
[ [ "swage", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ] | |
], |
"difficulty": 3, | ||
"time": "5 m", | ||
"book_learn": [ [ "recipe_bullets", 2 ], [ "mag_rifle", 3 ] ], | ||
"tools": [ [ [ "hydraulic_press", 100 ] ], [ [ "forge", 50 ] ] ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"tools": [ [ [ "hydraulic_press", 100 ] ], [ [ "forge", 50 ] ] ], | |
"tools": [ | |
[ [ "hydraulic_press", 10 ] ], | |
[ [ "forging_standard", 1, "LIST" ] ], | |
[ [ "swage", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ] | |
], |
"difficulty": 5, | ||
"time": "5 m", | ||
"book_learn": [ [ "recipe_bullets", 2 ], [ "mag_rifle", 3 ] ], | ||
"tools": [ [ [ "hydraulic_press", 100 ] ], [ [ "forge", 50 ] ] ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"tools": [ [ [ "hydraulic_press", 100 ] ], [ [ "forge", 50 ] ] ], | |
"tools": [ | |
[ [ "hydraulic_press", 10 ] ], | |
[ [ "forging_standard", 1, "LIST" ] ], | |
[ [ "swage", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ] | |
], |
Paaaaiiin, just now chucked the review at you XD |
data/json/items/resources/metal.json
Outdated
"color": "light_gray", | ||
"name": { "str_sp": "cartridge brass" }, | ||
"category": "scrap_metal", | ||
"description": "Some brass that has been made specifically to be formed into bullets.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor gripe. You are crafting cartridge casings out of this brass, not bullets.
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I has plans for a potential follow-up to this, notably:
- Grid furniture version of this.
- Seeing if plastic scrap is low enough in weight that it'll be feasible to add shotshell recipes too (looks like just barely, plastic scrap is 5 grams while both .410 and 12 gauge hulls are 8 grams, so it'd be viable for 1 hull to be made at a time using 3 brass and 1 plastic scrap).
- Uncrafts for casings (reversible recipes would technically work but be kinda annoying given the time costs and tool requirements).
Purpose of change (The Why)
Can't craft casings right now, which are mostly easy enough to craft.
Describe the solution (The How)
Adds recipes for casings
The recipes use a variable skill level, from 3 to 7, and an amount of brass equal to the casing weight
Adds an item and it's recipe : cartridge brass - used for making casings
Adds a hydraulic press item that's obtained by deconstructing a furniture hydraulic press, it eats heavy batteries to operate
Describe alternatives you've considered
The whole process would take a bunch of different machines in real life, which would create somewhat needless bloat.
Testing
Create world, learn all recipes using debug
Search for casing
Search for brass
Deconstruct a hydraulic press (usually garages and such have them)
Same as above, no crashes or errors
Additional context
Somewhat of an issue : the hydraulic press item doesn't have a sprite and I don't know how to fix it, if anyone can do it please do
None of my attempts at fixing said issue worked
Checklist
Mandatory
I wrote the PR title in conventional commit format.
I ran the code formatter.
I've committed my changes to new branch that isn't
main
so it won't cause conflict when updatingmain
branch later.I understand that, unless specified otherwise, my contributions will fall under the AGPL v3.0 and/or CC-BY-SA 4.0 licenses