fix(content): NON_FOULING flag not working due to typo

[scarf005]

Summary

SUMMARY: Bugfixes "Fix NON_FOULING flag not working due to typo"

Purpose of change

• fixes Lasers get fouled and can be mended, firing an unlubricated laser crashes to desktop #3645

DDA removed their accidental hyphen-based item flags to underscore based ones, BN didn't follow. Thus BN was using NON-FOULING. #3354 introduced NON_FOULING, which made the hardcoded flag look for NON_FOULING.

Describe the solution

search and replace

Describe alternatives you've considered

hecc.

Testing

spawned and fired A7 laser rifle a lot.
before: got fouling
after: got no fouling

[chaosvolt]

There being two ammo effect defs and both of them having been the hyphen version feels mildly fucking cursed. XD

[scarf005]

@olanti-p should i keep NON_FOULING as both ammo effect and json flag? afaik former is for ammo and latter is for guns

[olanti-p]

It doesn't look like we're using the ammo effect in any meaningful capacity (i.e. all relevant guns that fire these ammo should already have the NON_FOULING flag), but there might be mods that add non-fouling gunpowder-based ammo? Does such combination even work?

[chaosvolt]

Switched to Scarf's repo and slapped it with the search-in-folder stick, NON-FOULING no longer appears anywhere in the data, doc, or src folders. NON_FOULING meanwhile appears in expected areas, though it's presently absent from documentation folder.

Also searched the trio of relevant folders for NONFOULING to really idiotproof things, no hits as expected.