Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported items flags optimization from DDA #3354

Merged
merged 6 commits into from
Oct 5, 2023

Conversation

Vollch
Copy link
Contributor

@Vollch Vollch commented Oct 3, 2023

Summary

SUMMARY: Infrastructure "Ported items flags optimization from DDA"

Purpose of change

Ported PRs:

Describe the solution

Everything is described in linked PRs.

Describe alternatives you've considered

Down the line of "flags rework" there will be one more big PR, i'm still considering to port that thing too before giving it a good play test. (Small things can be picked up at any moment) Ported.

Testing

Not tested at all. It compiles, runs, and seems to work. But due to amount of changes it need much better testing than i did so far. Hence the draft.

Additional context

Flags list is a bit messy. I tried to clean it up a bit - adding missing declaration\json record, and removing those one which not mentioned in BN in any form, but there's still some flags which doesn't seems to do anything at all.

Co-authored-by: Aivean <aiveeen@gmail.com>
@github-actions github-actions bot added src changes related to source code. JSON related to game datas in JSON format. tests changes related to tests labels Oct 3, 2023
@scarf005 scarf005 self-requested a review October 4, 2023 05:05
@scarf005 scarf005 self-assigned this Oct 4, 2023
Vollch and others added 2 commits October 4, 2023 16:23
@Vollch Vollch marked this pull request as ready for review October 4, 2023 14:34
@scarf005 scarf005 self-requested a review October 5, 2023 07:04
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before

image

After

image

built locally, ran some tests, PC didn't explode. spawned an evac shelter and waited.

@scarf005 scarf005 added this pull request to the merge queue Oct 5, 2023
Merged via the queue into cataclysmbnteam:upload with commit fc9f59f Oct 5, 2023
@Vollch Vollch deleted the flags branch November 25, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. src changes related to source code. tests changes related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants