-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ported items flags optimization from DDA #3354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aivean <aiveeen@gmail.com>
scarf005
reviewed
Oct 4, 2023
Co-authored-by: Aivean <aiveeen@gmail.com>
scarf005
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was referenced Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Ported items flags optimization from DDA"
Purpose of change
Ported PRs:
Describe the solution
Everything is described in linked PRs.
Describe alternatives you've considered
Down the line of "flags rework" there will be one more big PR, i'm still considering to port that thing too before giving it a good play test. (Small things can be picked up at any moment)Ported.Testing
Not tested at all. It compiles, runs, and seems to work. But due to amount of changes it need much better testing than i did so far. Hence the draft.
Additional context
Flags list is a bit messy. I tried to clean it up a bit - adding missing declaration\json record, and removing those one which not mentioned in BN in any form, but there's still some flags which doesn't seems to do anything at all.