Fix mission names misused as mission description #3376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaosvolt
added a commit
to chaosvolt/cdda-arcana-mod
that referenced
this pull request
Oct 6, 2023
In preparation for cataclysmbnteam/Cataclysm-BN#3376
chaosvolt
approved these changes
Oct 6, 2023
This was referenced Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixed mission names misused as mission description"
Purpose of change
Fix #3229.
Prevent missions from having long and verbose names that look ugly in the UI.
Describe the solution
The bug was caused by use of tags in mission name, but tags are supported only in mission description.
1st commit changes name into description for affected missions.
2nd commit adds automated check that discourages long names in favor of using the
descriptionfield.3rd commit tweaks names of the missions that trigger the new check.
Describe alternatives you've considered
40 is an arbitrary limit, can be changed.
Testing
(The name does not match because Leo is the NPC I've debug-added the mission to)