Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding flesh raptors to mainline #2184

Closed

Conversation

thelonestander
Copy link
Contributor

@thelonestander thelonestander commented Nov 12, 2022

I always thought Flesh raptors from DDA are cool so I added them to BN.

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Summary CONTENT "Added Flesh raptors from DDA to mainline BN

Purpose of change

As I said ive loved the flesh raptors in DDA and since we were able to port this fix #1865 I figured it would be nice to have a monster in game that uses this.

Describe the solution

Just moved the files over from my mod and fixed up the spell shapes.

Describe alternatives you've considered

Leaving it in my mod

Testing

Tested in a new game with new mods, spawned some fleshy boys in they work!

Additional context

N/a

I always thought Flesh raptors from DDA are cool

Co-Authored-By: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 12, 2022
@Coolthulhu Coolthulhu self-assigned this Nov 15, 2022
},
{
"type": "monstergroup",
"name": "GROUP_ZOMBIE_UPGRADE",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are those groups "redefined" like this? It should probably be added to the original group. Same for the rest, below.

@LyleSY
Copy link
Contributor

LyleSY commented Dec 16, 2022

Great idea, just needs the tweaks Coolthulhu asked for and it should be fine to merge. As is, defining the same monster groups twice in the same file in mainline won't work like it does with a mod

@thelonestander
Copy link
Contributor Author

Should be good to go now.

@Coolthulhu
Copy link
Member

Tested them and found a bunch of issues:

  • With 3D vision, the raptors can stay above player and won't go down to attack
  • Pupating zombies can cause massive stunlocks in melee - I assume it's because of their sludge trail, which seems to apply move drain when it creates sludge under the player
  • Raptors have evolutions, but pupating zombies do not - evolved raptors will only happen if the player gets near to spawn the raptors, then goes away to let them evolve
  • Shady pupating zombies don't seem to have any spawn group or other non-debug way of existing
  • (Possibly) Shadow raptors have that weird darkness invisibility - not sure if we want that

I don't think they are ready for BN in current state.

@Zlorthishen
Copy link
Contributor

With 3D vision, the raptors can stay above player and won't go down to attack
is that a json issue or a c++ issue?

@Coolthulhu
Copy link
Member

C++, it needs some fixes to 3D monsters.

@Coolthulhu Coolthulhu removed their assignment Feb 15, 2023
@thelonestander thelonestander deleted the flesh_raptors branch February 22, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants