-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appliance update. Extend crafting_pseudo_item
. JSONize freezers and fridges. Update Freezers/Fridges to use iexamine::transform
#2172
Appliance update. Extend crafting_pseudo_item
. JSONize freezers and fridges. Update Freezers/Fridges to use iexamine::transform
#2172
Conversation
Updates all relevant functions that depend on it. Adds FOODCO kitchen buddy to construction list. Gives vehicle welding rig construction a soldering iron to go with the welder.
fc77928
to
df82516
Compare
The future shall belong to the cockroaches.
8e98eb8
to
5c81208
Compare
Based on tweaked components. Goal is a little trimming of weight
1e4ee4d
to
3115e26
Compare
I think this is what Clang wants from me?
Add documentation for flags and expansion of crafting_pseudo_items.
85f957e
to
c395a6d
Compare
Side notes:
|
Edit: Edit2: |
Updated iexamine transform to use similar structure as iexamine fireplace.
crafting_pseudo_item
. JSONize freezers and fridges.crafting_pseudo_item
. JSONize freezers and fridges. Update Freezers/Fridges to use `iexamine::transform
crafting_pseudo_item
. JSONize freezers and fridges. Update Freezers/Fridges to use `iexamine::transformcrafting_pseudo_item
. JSONize freezers and fridges. Update Freezers/Fridges to use iexamine::transform
e3c7b9d
to
f8aac99
Compare
3a66503
to
27abb64
Compare
With a JSON example in the welding rig
There's no reason to initialise an entirely new variable.
f52bc4c
to
f4653b3
Compare
Vehicle parts have a separate enabled variable to decide if it's on or not, we don't have that for furniture, so FRIDGE and FREEZER flags can only be put on the active versions of said furniture.
Abstract furniture description updated to reflect abstract status.
a484097
to
b264054
Compare
b264054
to
7868b10
Compare
Had to test freezers specifically. Looks like they do preserve things 100%, as expected. Didn't think about balance at the time. But it certainly could use rebalancing: freezer is just the tiniest bit more expensive than fridge, but vastly more useful. Should be at least 3x as expensive. |
Summary
SUMMARY: Infrastructure "Appliance update. Extend
crafting_pseudo_item
. JSONize freezers and fridges. Update Freezers/Fridges to useiexamine::transform
"Purpose of change
FOODCO kitchen buddy cannot be installed as furniture; grid welder and soldering iron are separate due to function limitations; there's no damn full size freezer or refrigerated tanks for the grid.
Describe the solution
To make all of these a reality.
crafting_pseudo_item
to be either an array or an object. Update all the relevant code includingACT_REPAIR
group,reload_furniture
,use_furn_fake_item
,form_from_map
and all the other fun functions...iexamine::transform
so that you can choose to either pick up items or transform furniture, preventing automatic transformation of furniture if you happen to be using examine instead of get.iexamine::transform
and deprecatetoggle refrigerator/freezer
construction group.Work still to be done
Add refrigerated tanks.Bunch of issues that should be fixed in a separate PR before this is a good idea. See Additional Content for more info.Describe alternatives you've considered
Discarded, it's easier for me to make it a flag and makes it easier to add more furniture of the same type.
Potentially disastrous, hacky as fuck, discarded.
Testing
Additional context
While working on this I considered removing the
USES_GRID_POWER
flag from being needed, having it implicit for any battery powered appliance wired into the grid. It was suggested by @Coolthulhu that this might lead to unintended behaviour in the future, so for now that idea is tabled.Fridge tanks as an appliance were not added for a few reasons.