Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid welding rig doesn't work as soldering iron #1593

Closed
AngelicosPhosphoros opened this issue Jun 2, 2022 · 2 comments
Closed

Grid welding rig doesn't work as soldering iron #1593

AngelicosPhosphoros opened this issue Jun 2, 2022 · 2 comments
Labels
needs verification Does this bug (still) happen? Needs independent reproduction.

Comments

@AngelicosPhosphoros
Copy link
Contributor

Describe the bug

It is constructed from same vehicle welding rig as in cars but doesn't act as soldering iron unlike vehicle part.

It uses same fake item so acts absolutely identically to grid arc welder but uses soldering iron as component.

Steps To Reproduce

  1. Acquire vehicle welding rig.
  2. Place it in charged power grid.
  3. Try to do something which require soldering iron (e.g. disassemble electronics).
  4. Fail to do so because you lack soldering iron.

Also you can:
5. deconstruct grid welding rig.
6. put it in a vehicle.
7. Enjoy your soldering iron once again.

Expected behavior

Either:

  1. Since it uses vehicle part as component, it should act identically.
  2. Or just remove this grid welding rig because there are already both grid arc welder and grid soldering iron.

Screenshots

No response

Versions and configuration

Game Version: de64c76

Additional context

No response

@olanti-p olanti-p moved this to Todo - Bugs in BN stable TODO list Aug 24, 2022
@olanti-p olanti-p moved this from TODO - Bug to TODO - Feature in BN stable TODO list Sep 21, 2022
@olanti-p olanti-p moved this from TODO - Feature to TODO - Bug in BN stable TODO list Sep 21, 2022
@olanti-p
Copy link
Contributor

DDA issue for reference: CleverRaven/Cataclysm-DDA#34851
PR that fixed this in DDA has a ton of conflicts with BN, so it might be easier to come up with some BN-specific solution instead of porting.

@Drugitechnik Drugitechnik added the needs verification Does this bug (still) happen? Needs independent reproduction. label Oct 8, 2022
@KheirFerrum
Copy link
Collaborator

This should be fixed by #2172 which extends crafting_pseudo_item to allow the welding rig appliance to act as both a welding rig and soldering iron.

@github-project-automation github-project-automation bot moved this from TODO - Bug to Done in BN stable TODO list Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs verification Does this bug (still) happen? Needs independent reproduction.
Projects
None yet
Development

No branches or pull requests

4 participants