Updated Github matrix and Makefile to use COMPILER parameter #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ced296b to
f861134
Compare
Also little changes in code and some documenting comments.
f861134 to
eaecb2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Fix CI builds"
Purpose of change
Fixes #1627
Describe the solution
Made Makefile look into COMPILER parameter
Describe alternatives you've considered
Just remove Makefile and use only cmake.
Testing
Not yet
Additional context
Found out that we don't actually use compilers from matrix when trying to bump C++ version.
#1624
Also little changes in code and some documenting comments.