New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matrix builds ignore compiler setting #1627

Closed

AngelicosPhosphoros opened this issue Jun 18, 2022 · 0 comments · Fixed by #1632

Contributor

AngelicosPhosphoros commented Jun 18, 2022

Describe the bug

Our compiler in build matrix expected to be set here: https://github.com/AngelicosPhosphoros/Cataclysm-BN/blob/f8f730acf8284932a8427f56d8a5ccb146fc1a48/.github/workflows/matrix.yml#L73

But build-scripts/build.sh reads it only if we enabled cmake and doesn't store it anywhere
https://github.com/AngelicosPhosphoros/Cataclysm-BN/blob/f8f730acf8284932a8427f56d8a5ccb146fc1a48/build-scripts/build.sh#L41

And our Makefile doesn't even try to look at COMPILER and uses CXX variable.
https://github.com/AngelicosPhosphoros/Cataclysm-BN/blob/f8f730acf8284932a8427f56d8a5ccb146fc1a48/Makefile#L256

So I end up wondering why my CI build https://github.com/cataclysmbnteam/Cataclysm-BN/runs/6946108615?check_suite_focus=true uses default g++ instead of clang++-11 which I asked.

Seems that our CI was broken all this time.

Steps To Reproduce

Just open any PR.

Expected behavior

Our compilation matrix try every compiler from list.

Screenshots

Versions and configuration

Unrelated.

Additional context

No response

AngelicosPhosphoros mentioned this issue

Updated Github matrix and Makefile to use COMPILER parameter #1632

Merged

Coolthulhu closed this as completed in #1632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment