Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add capability of using different resolution/shape in get_mmr_* #6

Closed
wants to merge 1 commit into from
Closed

add capability of using different resolution/shape in get_mmr_* #6

wants to merge 1 commit into from

Conversation

KrisThielemans
Copy link
Contributor

pass the outres parameter to ToPetMmr. This meant I had to encode the resolution in the cached filename

fixes #4

@KrisThielemans
add capability of using different resolution/shape in get_mmr_*
0d6c5d1 
pass the `outres` parameter to ToPetMmr. This meant I had to encode the
resolution in the cached filename.
@KrisThielemans
Copy link
Contributor Author

This PR does not address the second request in #4 (allowing to use arbitrary voxel-size). This is a bit more tricky, and would need encoding res/shape in the cached filename presumably.

@KrisThielemans KrisThielemans mentioned this pull request Jul 28, 2020
Merged
@casperdcl
Copy link
Owner

Sorry somehow missed the notification about this! Will review and merge in <24h

@casperdcl
Copy link
Owner

superseded by #8

@casperdcl casperdcl closed this Sep 16, 2020
@casperdcl casperdcl mentioned this pull request Sep 16, 2020
Merged
casperdcl added a commit that referenced this pull request Sep 16, 2020
@casperdcl
Merge branch 'get_label_probabilities' into devel
7eaa3ee 
- add `get_label_probabilities() (closes #8 <- fixes #2)
  - add `Act.all_labels`
  - expose `Act`
- add `trim_zeros_ROI()`
- cache resolution and PET activity class (closes #6 <- fixes #4)
- make `toPetMmr()` return `ndarray`
- update example images
- update dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow specifying different resolution
2 participants
@KrisThielemans @casperdcl