Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for to-be-closed variables for machine Lua API #77

Merged
merged 6 commits into from
Jul 18, 2023
Merged

Add support for to-be-closed variables for machine Lua API #77

merged 6 commits into from
Jul 18, 2023

Conversation

edubart
Copy link
Collaborator

@edubart edubart commented Jun 6, 2023 •
edited
Loading

This implements #42 and #69

Both issue allow us to simplify some Lua tests.

This PR depends on

This PR depends on the above PRs, they should be reviewed first.

@edubart edubart added the enhancement New feature or request label Jun 6, 2023
@edubart edubart self-assigned this Jun 6, 2023
@edubart edubart added this to the v0.15.0 milestone Jun 6, 2023
This was linked to issues Jun 6, 2023
Use to-be-closed Lua values in machine Lua tests #42
Closed
Machine config usability enhancements for testing #69
Closed
@edubart edubart mentioned this pull request Jun 6, 2023
Draft
@edubart edubart force-pushed the feature/lua-close branch 3 times, most recently from 1c628c6 to 5527c1e Compare June 6, 2023 18:02
@edubart edubart requested a review from diegonehab June 6, 2023 18:41
@edubart edubart force-pushed the feature/lua-close branch from 5527c1e to d20e962 Compare June 12, 2023 17:25
@edubart edubart changed the base branch from main to feature/luacheck June 12, 2023 17:26
@edubart edubart force-pushed the feature/luacheck branch 3 times, most recently from b18ec01 to f4ace20 Compare June 13, 2023 16:46
@edubart edubart force-pushed the feature/luacheck branch 3 times, most recently from b7b19f6 to e0c8246 Compare June 27, 2023 14:47
@edubart edubart force-pushed the feature/lua-close branch from d20e962 to 5d74b96 Compare June 27, 2023 14:53
@edubart edubart requested a review from vfusco June 27, 2023 17:08
diegonehab
diegonehab previously approved these changes Jun 27, 2023
View reviewed changes
@edubart edubart force-pushed the feature/luacheck branch 2 times, most recently from bbf09ab to aa8826c Compare June 29, 2023 13:01
@edubart edubart force-pushed the feature/lua-close branch from d36604b to fa35405 Compare June 29, 2023 13:04
@edubart edubart force-pushed the feature/luacheck branch from aa8826c to 51cc116 Compare June 29, 2023 17:25
@edubart edubart force-pushed the feature/lua-close branch from fa35405 to da122dc Compare June 29, 2023 17:25
@edubart edubart force-pushed the feature/luacheck branch from 51cc116 to 5cf1933 Compare July 11, 2023 14:47
@edubart edubart force-pushed the feature/lua-close branch from da122dc to 6e8950a Compare July 11, 2023 14:49
@edubart edubart mentioned this pull request Jul 17, 2023
Closed
2 tasks
vfusco
vfusco previously approved these changes Jul 18, 2023
View reviewed changes
Base automatically changed from feature/luacheck to main July 18, 2023 16:47
@edubart edubart dismissed stale reviews from vfusco and diegonehab July 18, 2023 16:47

The base branch was changed.

@edubart edubart requested review from vfusco and diegonehab July 18, 2023 16:51
@edubart edubart merged commit 6e8950a into main Jul 18, 2023
@edubart edubart deleted the feature/lua-close branch July 18, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpolitzer mpolitzer mpolitzer approved these changes

@vfusco vfusco vfusco approved these changes

@diegonehab diegonehab Awaiting requested review from diegonehab

Assignees

@edubart edubart

Labels
enhancement New feature or request
Projects
Machine Emulator SDK
Status: Done
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.

Machine config usability enhancements for testing Use to-be-closed Lua values in machine Lua tests
4 participants
@edubart @mpolitzer @vfusco @diegonehab